chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm - Issue 1172183002: Move StartsWith[ASCII] to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

Issue 1172183002: Move StartsWith[ASCII] to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@string_util3

Patch Set: merger Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

index 936ce5751103fb1b3bf15a41aa3f1b6258b4b182..9cef5fa94b8881782b13833c328a813140648e63 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

@@ -526,9 +526,9 @@ NSAttributedString* CreateClassifiedAttributedString(

match.GetAdditionalInfo(kACMatchPropertyContentsStartIndex),

&contentsStartIndex);

// Ignore invalid state.

- if (!StartsWith(match.fill_into_edit, inputText, true)

- || !EndsWith(match.fill_into_edit, match.contents, true)

- || ((size_t)contentsStartIndex >= inputText.length())) {

+ if (!base::StartsWith(match.fill_into_edit, inputText, true) ||

+ !EndsWith(match.fill_into_edit, match.contents, true) ||

+ ((size_t)contentsStartIndex >= inputText.length())) {

return 0;

}

bool isContentsRTL = (base::i18n::RIGHT_TO_LEFT ==