Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 1172183002: Move StartsWith[ASCII] to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@string_util3
Patch Set: merger Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.cc
diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc
index da366f28f3608468d3b1c6b81e811def05582451..9995a218c98037f3d9441332a0e00804fe5e746e 100644
--- a/components/password_manager/core/browser/password_form_manager.cc
+++ b/components/password_manager/core/browser/password_form_manager.cc
@@ -168,7 +168,7 @@ PasswordFormManager::MatchResultMask PasswordFormManager::DoesManage(
origins_match =
observed_form_.origin.host() == form.origin.host() &&
observed_form_.origin.port() == form.origin.port() &&
- StartsWithASCII(new_path, old_path, /*case_sensitive=*/true);
+ base::StartsWithASCII(new_path, old_path, /*case_sensitive=*/true);
}
if (!origins_match)
@@ -392,7 +392,7 @@ void PasswordFormManager::OnRequestDone(
// instead of explicitly handling empty path matches.
bool is_credential_protected =
observed_form_.scheme == PasswordForm::SCHEME_HTML &&
- StartsWithASCII("/", login->origin.path(), true) &&
+ base::StartsWithASCII("/", login->origin.path(), true) &&
credential_scores[i] > 0 && !login->blacklisted_by_user;
// Passwords generated on a signup form must show on a login form even if
// there are better-matching saved credentials. TODO(gcasto): We don't

Powered by Google App Engine
This is Rietveld 408576698