chrome/test/chromedriver/chrome/web_view_impl.cc - Issue 1172183002: Move StartsWith[ASCII] to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/web_view_impl.cc

Issue 1172183002: Move StartsWith[ASCII] to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@string_util3

Patch Set: merger Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome/web_view_impl.cc

diff --git a/chrome/test/chromedriver/chrome/web_view_impl.cc b/chrome/test/chromedriver/chrome/web_view_impl.cc

index 93be27e699056e33bd31fdb4bd4812f95dc2c027..576bea2df38349f10bfffa951d49ff0aac414acd 100644

--- a/chrome/test/chromedriver/chrome/web_view_impl.cc

+++ b/chrome/test/chromedriver/chrome/web_view_impl.cc

@@ -155,7 +155,7 @@ Status WebViewImpl::HandleReceivedEvents() {

Status WebViewImpl::Load(const std::string& url) {

// Javascript URLs will cause a hang while waiting for the page to stop

// loading, so just disallow.

- if (StartsWithASCII(url, "javascript:", false))

+ if (base::StartsWithASCII(url, "javascript:", false))

return Status(kUnknownError, "unsupported protocol");

base::DictionaryValue params;

params.SetString("url", url);