tools/gn/target.cc - Issue 1172183002: Move StartsWith[ASCII] to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/target.cc

Issue 1172183002: Move StartsWith[ASCII] to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@string_util3

Patch Set: merger Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/target.cc

diff --git a/tools/gn/target.cc b/tools/gn/target.cc

index 2ea285943248ffdef6ddabf0044738351d791d5b..0b189e63b4850690187cab57ce3458a5e34e7537 100644

--- a/tools/gn/target.cc

+++ b/tools/gn/target.cc

@@ -217,7 +217,7 @@ std::string Target::GetComputedOutputName(bool include_prefix) const {

const Tool* tool = toolchain_->GetToolForTargetFinalOutput(this);

const std::string& prefix = tool->output_prefix();

// Only add the prefix if the name doesn't already have it.

- if (!StartsWithASCII(name, prefix, true))

+ if (!base::StartsWithASCII(name, prefix, true))

result = prefix;

}