Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1171973003: Move StringToUpperASCII to base namespace (Closed)

Created:
5 years, 6 months ago by brettw
Modified:
5 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, yusukes+watch_chromium.org, mlamouri+watch-content_chromium.org, tburkard+watch_chromium.org, johnme+watch_chromium.org, browser-components-watch_chromium.org, stevenjb+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, grt+watch_chromium.org, tzik, jam, nona+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, michaeln, penghuang+watch_chromium.org, nhiroki, gavinp+prer_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, rouslan+autofillwatch_chromium.org, davidben+watch_chromium.org, hashimoto+watch_chromium.org, feature-media-reviews_chromium.org, wfh+watch_chromium.org, shuchen+watch_chromium.org, mvanouwerkerk+watch_chromium.org, davemoore+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, peter+watch_chromium.org, James Su, kinuko+fileapi, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move StringToUpperASCII to base namespace Removes some unnecessary base:: qualifications in the base files I touched. clang-formatted file_util_unittest because lots of wrapping changed with this removal (seems to be a big improvement). BUG= Committed: https://crrev.com/7622fbed9871c8c9ac61b4ea1aef36b0cf0fc144 Cr-Commit-Position: refs/heads/master@{#333560}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -223 lines) Patch
M base/environment.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/files/file_util_unittest.cc View 13 chunks +72 lines, -158 lines 0 comments Download
M base/guid_unittest.cc View 4 chunks +13 lines, -10 lines 0 comments Download
M base/strings/string_util.h View 2 chunks +11 lines, -11 lines 0 comments Download
M base/strings/string_util_unittest.cc View 8 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/dbus/printer_service_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/push_messaging/push_messaging_app_identifier.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_url_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/l10n_string_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/address.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_country.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/core/viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/cloud_policy_validator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/core/language_detection/language_detection_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/appcache/web_application_cache_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/android/phone_number_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/runtime_custom_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/mime_util.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/http/http_auth_handler_ntlm_portable.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_util_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M storage/common/fileapi/file_system_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/chromeos/input_method_descriptor.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
5 years, 6 months ago (2015-06-09 18:02:57 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171973003/1
5 years, 6 months ago (2015-06-09 18:04:01 UTC) #4
sky
LGTRM
5 years, 6 months ago (2015-06-09 19:25:18 UTC) #5
sky
LGTM
5 years, 6 months ago (2015-06-09 19:25:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171973003/1
5 years, 6 months ago (2015-06-09 20:12:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-09 20:20:27 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 20:21:18 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7622fbed9871c8c9ac61b4ea1aef36b0cf0fc144
Cr-Commit-Position: refs/heads/master@{#333560}

Powered by Google App Engine
This is Rietveld 408576698