components/translate/core/language_detection/language_detection_util.cc - Issue 1171973003: Move StringToUpperASCII to base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/language_detection/language_detection_util.cc

Issue 1171973003: Move StringToUpperASCII to base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/cloud_policy_validator_unittest.cc ('k') | content/child/appcache/web_application_cache_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/core/language_detection/language_detection_util.cc

diff --git a/components/translate/core/language_detection/language_detection_util.cc b/components/translate/core/language_detection/language_detection_util.cc

index ab25a7530b4cee704fbfc96ac2fecec387a42374..3cdbe7f435c62fa3e3bc995f5a9576bc645ae447 100644

--- a/components/translate/core/language_detection/language_detection_util.cc

+++ b/components/translate/core/language_detection/language_detection_util.cc

@@ -301,7 +301,7 @@ void CorrectLanguageCodeTypo(std::string* code) {

size_t dash_index = code->find('-');

if (dash_index != std::string::npos) {

*code = base::StringToLowerASCII(code->substr(0, dash_index)) +

- StringToUpperASCII(code->substr(dash_index));

+ base::StringToUpperASCII(code->substr(dash_index));

} else {

*code = base::StringToLowerASCII(*code);

}