chrome/browser/prerender/prerender_manager.cc - Issue 1171973003: Move StringToUpperASCII to base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prerender/prerender_manager.cc

Issue 1171973003: Move StringToUpperASCII to base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/prerender/prerender_manager.cc

diff --git a/chrome/browser/prerender/prerender_manager.cc b/chrome/browser/prerender/prerender_manager.cc

index 30fde0f587061809c98e221d689357f384da7b2a..58d621582227854b8d95193d548376a14f82a486 100644

--- a/chrome/browser/prerender/prerender_manager.cc

+++ b/chrome/browser/prerender/prerender_manager.cc

@@ -740,7 +740,7 @@ bool PrerenderManager::HasRecentlyBeenNavigatedTo(Origin origin,

bool PrerenderManager::IsValidHttpMethod(const std::string& method) {

// method has been canonicalized to upper case at this point so we can just

// compare them.

- DCHECK_EQ(method, StringToUpperASCII(method));

+ DCHECK_EQ(method, base::StringToUpperASCII(method));

for (size_t i = 0; i < arraysize(kValidHttpMethods); ++i) {

if (method.compare(kValidHttpMethods[i]) == 0)

return true;