Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: net/http/http_util_unittest.cc

Issue 1171973003: Move StringToUpperASCII to base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_handler_ntlm_portable.cc ('k') | storage/common/fileapi/file_system_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_util_unittest.cc
diff --git a/net/http/http_util_unittest.cc b/net/http/http_util_unittest.cc
index 71602844ad8d4054b08413c8d372a20ab83fc3d9..980c3886ae02c90cc9e48a13bd63568db9d5c0d9 100644
--- a/net/http/http_util_unittest.cc
+++ b/net/http/http_util_unittest.cc
@@ -50,8 +50,9 @@ TEST(HttpUtilTest, IsSafeHeader) {
for (size_t i = 0; i < arraysize(unsafe_headers); ++i) {
EXPECT_FALSE(HttpUtil::IsSafeHeader(unsafe_headers[i]))
<< unsafe_headers[i];
- EXPECT_FALSE(HttpUtil::IsSafeHeader(StringToUpperASCII(std::string(
- unsafe_headers[i])))) << unsafe_headers[i];
+ EXPECT_FALSE(HttpUtil::IsSafeHeader(
+ base::StringToUpperASCII(std::string(unsafe_headers[i]))))
+ << unsafe_headers[i];
}
static const char* const safe_headers[] = {
"foo",
@@ -95,8 +96,9 @@ TEST(HttpUtilTest, IsSafeHeader) {
};
for (size_t i = 0; i < arraysize(safe_headers); ++i) {
EXPECT_TRUE(HttpUtil::IsSafeHeader(safe_headers[i])) << safe_headers[i];
- EXPECT_TRUE(HttpUtil::IsSafeHeader(StringToUpperASCII(std::string(
- safe_headers[i])))) << safe_headers[i];
+ EXPECT_TRUE(HttpUtil::IsSafeHeader(
+ base::StringToUpperASCII(std::string(safe_headers[i]))))
+ << safe_headers[i];
}
}
« no previous file with comments | « net/http/http_auth_handler_ntlm_portable.cc ('k') | storage/common/fileapi/file_system_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698