components/policy/core/common/cloud/cloud_policy_validator_unittest.cc - Issue 1171973003: Move StringToUpperASCII to base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/cloud_policy_validator_unittest.cc

Issue 1171973003: Move StringToUpperASCII to base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/dom_distiller/core/viewer.cc ('k') | components/translate/core/language_detection/language_detection_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/cloud_policy_validator_unittest.cc

diff --git a/components/policy/core/common/cloud/cloud_policy_validator_unittest.cc b/components/policy/core/common/cloud/cloud_policy_validator_unittest.cc

index e88d4317c010bebe7950442e3027cd8c8441987a..28a3d21f27717382b248be779575b279ec1667e7 100644

--- a/components/policy/core/common/cloud/cloud_policy_validator_unittest.cc

+++ b/components/policy/core/common/cloud/cloud_policy_validator_unittest.cc

@@ -162,7 +162,7 @@ TEST_F(CloudPolicyValidatorTest, SuccessfulRunValidationWithNoDMTokens) {

TEST_F(CloudPolicyValidatorTest, UsernameCanonicalization) {

policy_.policy_data().set_username(

- StringToUpperASCII(std::string(PolicyBuilder::kFakeUsername)));

+ base::StringToUpperASCII(std::string(PolicyBuilder::kFakeUsername)));

Validate(CheckStatus(CloudPolicyValidatorBase::VALIDATION_OK));

}

« no previous file with comments | « components/dom_distiller/core/viewer.cc ('k') | components/translate/core/language_detection/language_detection_util.cc » ('j') | no next file with comments »