content/child/appcache/web_application_cache_host_impl.cc - Issue 1171973003: Move StringToUpperASCII to base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/appcache/web_application_cache_host_impl.cc

Issue 1171973003: Move StringToUpperASCII to base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/child/appcache/web_application_cache_host_impl.cc

diff --git a/content/child/appcache/web_application_cache_host_impl.cc b/content/child/appcache/web_application_cache_host_impl.cc

index bf110b16e4e9fc8b17e0ad19a84057f15637b5f3..c7328b39960ef1ec976bed0fe54af2549edf6739 100644

--- a/content/child/appcache/web_application_cache_host_impl.cc

+++ b/content/child/appcache/web_application_cache_host_impl.cc

@@ -167,7 +167,7 @@ void WebApplicationCacheHostImpl::willStartMainResourceRequest(

std::string method = request.httpMethod().utf8();

is_get_method_ = (method == kHttpGETMethod);

- DCHECK(method == StringToUpperASCII(method));

+ DCHECK(method == base::StringToUpperASCII(method));

const WebApplicationCacheHostImpl* spawning_host_impl =

static_cast<const WebApplicationCacheHostImpl*>(spawning_host);