chrome/installer/util/l10n_string_util.cc - Issue 1171973003: Move StringToUpperASCII to base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/l10n_string_util.cc

Issue 1171973003: Move StringToUpperASCII to base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/util/l10n_string_util.cc

diff --git a/chrome/installer/util/l10n_string_util.cc b/chrome/installer/util/l10n_string_util.cc

index bcd3a9e98bb640f14ccbf40229231bd4933c96f2..3e38788b5e47de40ea29169fe566354ae2dbafc4 100644

--- a/chrome/installer/util/l10n_string_util.cc

+++ b/chrome/installer/util/l10n_string_util.cc

@@ -73,7 +73,7 @@ std::wstring GetLocalizedEulaResource() {

// The resource names are more or less the upcased language names.

std::wstring language(GetLanguageSelector().selected_translation());

std::replace(language.begin(), language.end(), L'-', L'_');

- StringToUpperASCII(&language);

+ base::StringToUpperASCII(&language);

std::wstring resource(L"IDR_OEMPG_");

resource.append(language).append(L".HTML");