Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 117053002: remove SK_SCALAR_IS_[FLOAT,FIXED] and assume floats (Closed)

Created:
7 years ago by reed1
Modified:
7 years ago
Reviewers:
bsalomon, caryclark
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

remove SK_SCALAR_IS_[FLOAT,FIXED] and assume floats To keep the CL (slightly) managable, this does not make any changes to existing macros (e.g. SkScalarMul). Just tackling #ifdef constructs this time around. BUG= R=bsalomon@google.com, caryclark@google.com Committed: https://code.google.com/p/skia/source/detail?r=12712

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -1455 lines) Patch
M bench/MorphologyBench.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M bench/benchmain.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M experimental/SkSetPoly3To3_A.cpp View 1 chunk +7 lines, -22 lines 0 comments Download
M gm/blurs.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M gyp/SampleApp.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M include/config/SkUserConfig.h View 1 chunk +0 lines, -8 lines 0 comments Download
M include/core/SkFixed.h View 1 chunk +1 line, -5 lines 0 comments Download
M include/core/SkFloatBits.h View 1 chunk +2 lines, -7 lines 0 comments Download
M include/core/SkMatrix.h View 2 chunks +4 lines, -15 lines 0 comments Download
M include/core/SkPostConfig.h View 1 chunk +0 lines, -6 lines 0 comments Download
M include/core/SkPreConfig.h View 1 chunk +0 lines, -6 lines 0 comments Download
M include/core/SkRect.h View 2 chunks +0 lines, -8 lines 0 comments Download
M include/core/SkScalar.h View 4 chunks +144 lines, -242 lines 0 comments Download
M include/core/SkString.h View 1 chunk +1 line, -5 lines 0 comments Download
M include/utils/SkCamera.h View 1 chunk +4 lines, -11 lines 0 comments Download
M samplecode/SampleCircle.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
D samplecode/SampleOverflow.cpp View 1 chunk +0 lines, -108 lines 0 comments Download
M src/animator/SkDisplayMath.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M src/animator/SkDrawColor.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/animator/SkDrawGradient.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M src/animator/SkScript.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/animator/SkScriptTokenizer.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +2 lines, -16 lines 1 comment Download
M src/core/SkCubicClipper.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M src/core/SkEdge.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/core/SkEdge.cpp View 5 chunks +0 lines, -30 lines 0 comments Download
M src/core/SkFDot6.h View 1 chunk +2 lines, -7 lines 0 comments Download
M src/core/SkFlattenableBuffers.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkGeometry.cpp View 9 chunks +12 lines, -117 lines 0 comments Download
M src/core/SkLineClipper.cpp View 7 chunks +0 lines, -14 lines 0 comments Download
M src/core/SkMath.cpp View 3 chunks +3 lines, -7 lines 0 comments Download
M src/core/SkMatrix.cpp View 7 chunks +45 lines, -164 lines 0 comments Download
M src/core/SkPaint.cpp View 2 chunks +3 lines, -15 lines 0 comments Download
M src/core/SkPathMeasure.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/core/SkPicture.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkRect.cpp View 2 chunks +10 lines, -20 lines 0 comments Download
M src/core/SkScan.h View 2 chunks +0 lines, -22 lines 0 comments Download
M src/core/SkScan.cpp View 4 chunks +0 lines, -8 lines 0 comments Download
M src/core/SkScan_AntiPath.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M src/core/SkScan_Antihair.cpp View 5 chunks +0 lines, -10 lines 0 comments Download
M src/core/SkScan_Hairline.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/core/SkStrokerPriv.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M src/effects/SkArithmeticMode.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 2 chunks +0 lines, -227 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/gpu/GrPathUtils.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLPath.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLUniformManager.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/pdf/SkPDFTypes.cpp View 3 chunks +2 lines, -8 lines 0 comments Download
M src/ports/SkHarfBuzzFont.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/utils/SkCamera.cpp View 4 chunks +0 lines, -48 lines 0 comments Download
M src/utils/SkInterpolator.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/utils/SkParse.cpp View 2 chunks +1 line, -44 lines 0 comments Download
M src/utils/SkParsePath.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M src/xml/SkJSDisplayable.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M src/xml/SkXMLWriter.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/DrawBitmapRectTest.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M tests/DrawPathTest.cpp View 5 chunks +0 lines, -8 lines 0 comments Download
M tests/InfRectTest.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M tests/MathTest.cpp View 3 chunks +0 lines, -37 lines 0 comments Download
M tests/Matrix44Test.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M tests/MatrixTest.cpp View 6 chunks +0 lines, -27 lines 0 comments Download
M tests/PDFPrimitivesTest.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M tests/PathMeasureTest.cpp View 4 chunks +0 lines, -6 lines 0 comments Download
M tests/PathTest.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M tests/ScalarTest.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M tests/StringTest.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M tests/WritePixelsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/skia_test.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
reed1
kinda hard to manually review. At least check the public headers, and we can trust ...
7 years ago (2013-12-17 06:14:58 UTC) #1
reed1
7 years ago (2013-12-17 06:16:53 UTC) #2
caryclark
lgtm https://codereview.chromium.org/117053002/diff/1/src/core/SkCanvas.cpp File src/core/SkCanvas.cpp (right): https://codereview.chromium.org/117053002/diff/1/src/core/SkCanvas.cpp#newcode1459 src/core/SkCanvas.cpp:1459: static inline int pinIntForScalar(int x) { this inline ...
7 years ago (2013-12-17 13:07:13 UTC) #3
bsalomon
lgtm
7 years ago (2013-12-17 14:28:33 UTC) #4
reed1
7 years ago (2013-12-17 16:45:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r12712 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698