Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11570012: events: Update key-event handlers to not return EventResult. (Closed)

Created:
8 years ago by sadrul
Modified:
8 years ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, dcheng, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, James Su
Visibility:
Public.

Description

events: Update key-event handlers to not return EventResult. BUG=163618 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173171

Patch Set 1 #

Patch Set 2 : tot-merge-for-landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -156 lines) Patch
M ash/accelerators/accelerator_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/accelerators/accelerator_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_filter.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ash/drag_drop/drag_drop_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ash/launcher/launcher_tooltip_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/tooltips/tooltip_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/tooltips/tooltip_controller.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ash/wm/activation_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/activation_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/event_rewriter_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/event_rewriter_event_filter.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M ash/wm/overlay_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overlay_event_filter.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/system_modal_container_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_modal_container_event_filter.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M ash/wm/toplevel_window_event_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_window_event_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/user_activity_detector.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/user_activity_detector.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/user_activity_detector_unittest.cc View 4 chunks +10 lines, -5 lines 0 comments Download
M ash/wm/window_cycle_controller.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ash/wm/window_manager_unittest.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download
M ash/wm/workspace/frame_maximize_button.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/input/input.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 chunks +7 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/aura/root_window_unittest.cc View 4 chunks +5 lines, -8 lines 0 comments Download
M ui/aura/test/test_event_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/test_event_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/aura/test/test_window_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/test/test_window_delegate.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M ui/base/events/event_dispatcher_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/events/event_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/events/event_handler.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/base/events/event_target.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/events/event_target.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/corewm/compound_event_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/corewm/compound_event_filter.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M ui/views/corewm/focus_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/focus_controller.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/corewm/input_method_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/input_method_event_filter.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/views/corewm/window_modality_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/window_modality_controller.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_activation_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_activation_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M ui/views/widget/native_widget_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/root_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/root_view.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M ui/views/widget/widget.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sadrul
8 years ago (2012-12-13 23:29:29 UTC) #1
Ben Goodger (Google)
8 years ago (2012-12-14 00:13:05 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698