Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Unified Diff: ui/base/events/event_target.cc

Issue 11570012: events: Update key-event handlers to not return EventResult. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tot-merge-for-landing Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/events/event_target.h ('k') | ui/views/corewm/compound_event_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/events/event_target.cc
diff --git a/ui/base/events/event_target.cc b/ui/base/events/event_target.cc
index c587877160a0fd69e3d4db772c34f5018c9b8720..649c72211cf3364ec2675808a3047206eed2abc2 100644
--- a/ui/base/events/event_target.cc
+++ b/ui/base/events/event_target.cc
@@ -52,9 +52,10 @@ void EventTarget::OnEvent(Event* event) {
EventHandler::OnEvent(event);
}
-EventResult EventTarget::OnKeyEvent(KeyEvent* event) {
+void EventTarget::OnKeyEvent(KeyEvent* event) {
CHECK_EQ(this, event->target());
- return target_handler_ ? target_handler_->OnKeyEvent(event) : ER_UNHANDLED;
+ if (target_handler_)
+ target_handler_->OnKeyEvent(event);
}
EventResult EventTarget::OnMouseEvent(MouseEvent* event) {
« no previous file with comments | « ui/base/events/event_target.h ('k') | ui/views/corewm/compound_event_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698