Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2527)

Unified Diff: ash/tooltips/tooltip_controller.cc

Issue 11570012: events: Update key-event handlers to not return EventResult. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tot-merge-for-landing Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/tooltips/tooltip_controller.h ('k') | ash/wm/activation_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/tooltips/tooltip_controller.cc
diff --git a/ash/tooltips/tooltip_controller.cc b/ash/tooltips/tooltip_controller.cc
index 21dcab57f82e64613c36b9dfa59bf1ae66d53130..ef80f9bfb932211ab44c2d4a87fece2533188b14 100644
--- a/ash/tooltips/tooltip_controller.cc
+++ b/ash/tooltips/tooltip_controller.cc
@@ -249,7 +249,7 @@ void TooltipController::SetTooltipsEnabled(bool enable) {
UpdateTooltip(tooltip_window_);
}
-ui::EventResult TooltipController::OnKeyEvent(ui::KeyEvent* event) {
+void TooltipController::OnKeyEvent(ui::KeyEvent* event) {
// On key press, we want to hide the tooltip and not show it until change.
// This is the same behavior as hiding tooltips on timeout. Hence, we can
// simply simulate a timeout.
@@ -257,7 +257,6 @@ ui::EventResult TooltipController::OnKeyEvent(ui::KeyEvent* event) {
tooltip_shown_timer_.Stop();
TooltipShownTimerFired();
}
- return ui::ER_UNHANDLED;
}
ui::EventResult TooltipController::OnMouseEvent(ui::MouseEvent* event) {
« no previous file with comments | « ash/tooltips/tooltip_controller.h ('k') | ash/wm/activation_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698