Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: ui/base/events/event_handler.cc

Issue 11570012: events: Update key-event handlers to not return EventResult. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tot-merge-for-landing Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/events/event_handler.h ('k') | ui/base/events/event_target.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/events/event_handler.cc
diff --git a/ui/base/events/event_handler.cc b/ui/base/events/event_handler.cc
index df35e59d1c8592aaa724e86b06dbc967805367ef..85ec7d596623f9111d4cd69f5ff557eb49779f41 100644
--- a/ui/base/events/event_handler.cc
+++ b/ui/base/events/event_handler.cc
@@ -23,7 +23,7 @@ EventHandler::~EventHandler() {
void EventHandler::OnEvent(Event* event) {
ui::EventResult result = ui::ER_UNHANDLED;
if (event->IsKeyEvent())
- result = OnKeyEvent(static_cast<KeyEvent*>(event));
+ OnKeyEvent(static_cast<KeyEvent*>(event));
else if (event->IsMouseEvent())
result = OnMouseEvent(static_cast<MouseEvent*>(event));
else if (event->IsScrollEvent())
@@ -39,8 +39,7 @@ void EventHandler::OnEvent(Event* event) {
event->SetHandled();
}
-EventResult EventHandler::OnKeyEvent(KeyEvent* event) {
- return ui::ER_UNHANDLED;
+void EventHandler::OnKeyEvent(KeyEvent* event) {
}
EventResult EventHandler::OnMouseEvent(MouseEvent* event) {
« no previous file with comments | « ui/base/events/event_handler.h ('k') | ui/base/events/event_target.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698