Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: ui/aura/root_window_unittest.cc

Issue 11570012: events: Update key-event handlers to not return EventResult. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tot-merge-for-landing Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/aura/root_window.h" 5 #include "ui/aura/root_window.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 #include "ui/aura/client/event_client.h" 10 #include "ui/aura/client/event_client.h"
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 DISALLOW_COPY_AND_ASSIGN(NonClientDelegate); 74 DISALLOW_COPY_AND_ASSIGN(NonClientDelegate);
75 }; 75 };
76 76
77 // A simple event handler that consumes key events. 77 // A simple event handler that consumes key events.
78 class ConsumeKeyHandler : public test::TestEventHandler { 78 class ConsumeKeyHandler : public test::TestEventHandler {
79 public: 79 public:
80 ConsumeKeyHandler() {} 80 ConsumeKeyHandler() {}
81 virtual ~ConsumeKeyHandler() {} 81 virtual ~ConsumeKeyHandler() {}
82 82
83 // Overridden from ui::EventHandler: 83 // Overridden from ui::EventHandler:
84 virtual ui::EventResult OnKeyEvent(ui::KeyEvent* event) OVERRIDE { 84 virtual void OnKeyEvent(ui::KeyEvent* event) OVERRIDE {
85 test::TestEventHandler::OnKeyEvent(event); 85 test::TestEventHandler::OnKeyEvent(event);
86 return ui::ER_CONSUMED; 86 event->StopPropagation();
87 } 87 }
88 88
89 private: 89 private:
90 DISALLOW_COPY_AND_ASSIGN(ConsumeKeyHandler); 90 DISALLOW_COPY_AND_ASSIGN(ConsumeKeyHandler);
91 }; 91 };
92 92
93 Window* CreateWindow(int id, Window* parent, WindowDelegate* delegate) { 93 Window* CreateWindow(int id, Window* parent, WindowDelegate* delegate) {
94 Window* window = new Window( 94 Window* window = new Window(
95 delegate ? delegate : 95 delegate ? delegate :
96 test::TestWindowDelegate::CreateSelfDestroyingDelegate()); 96 test::TestWindowDelegate::CreateSelfDestroyingDelegate());
(...skipping 337 matching lines...) Expand 10 before | Expand all | Expand 10 after
434 // FilterFilter that tracks the types of events it's seen. 434 // FilterFilter that tracks the types of events it's seen.
435 class EventFilterRecorder : public ui::EventHandler { 435 class EventFilterRecorder : public ui::EventHandler {
436 public: 436 public:
437 typedef std::vector<ui::EventType> Events; 437 typedef std::vector<ui::EventType> Events;
438 438
439 EventFilterRecorder() {} 439 EventFilterRecorder() {}
440 440
441 Events& events() { return events_; } 441 Events& events() { return events_; }
442 442
443 // ui::EventHandler overrides: 443 // ui::EventHandler overrides:
444 virtual ui::EventResult OnKeyEvent(ui::KeyEvent* event) OVERRIDE { 444 virtual void OnKeyEvent(ui::KeyEvent* event) OVERRIDE {
445 events_.push_back(event->type()); 445 events_.push_back(event->type());
446 return ui::ER_UNHANDLED;
447 } 446 }
448 447
449 virtual ui::EventResult OnMouseEvent(ui::MouseEvent* event) OVERRIDE { 448 virtual ui::EventResult OnMouseEvent(ui::MouseEvent* event) OVERRIDE {
450 events_.push_back(event->type()); 449 events_.push_back(event->type());
451 return ui::ER_UNHANDLED; 450 return ui::ER_UNHANDLED;
452 } 451 }
453 452
454 virtual void OnScrollEvent(ui::ScrollEvent* event) OVERRIDE { 453 virtual void OnScrollEvent(ui::ScrollEvent* event) OVERRIDE {
455 events_.push_back(event->type()); 454 events_.push_back(event->type());
456 } 455 }
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
633 DeletingEventFilter() 632 DeletingEventFilter()
634 : delete_during_pre_handle_(false) {} 633 : delete_during_pre_handle_(false) {}
635 virtual ~DeletingEventFilter() {} 634 virtual ~DeletingEventFilter() {}
636 635
637 void Reset(bool delete_during_pre_handle) { 636 void Reset(bool delete_during_pre_handle) {
638 delete_during_pre_handle_ = delete_during_pre_handle; 637 delete_during_pre_handle_ = delete_during_pre_handle;
639 } 638 }
640 639
641 private: 640 private:
642 // Overridden from ui::EventHandler: 641 // Overridden from ui::EventHandler:
643 virtual ui::EventResult OnKeyEvent(ui::KeyEvent* event) OVERRIDE { 642 virtual void OnKeyEvent(ui::KeyEvent* event) OVERRIDE {
644 if (delete_during_pre_handle_) 643 if (delete_during_pre_handle_)
645 delete event->target(); 644 delete event->target();
646 return ui::ER_UNHANDLED;
647 } 645 }
648 646
649 virtual ui::EventResult OnMouseEvent(ui::MouseEvent* event) OVERRIDE { 647 virtual ui::EventResult OnMouseEvent(ui::MouseEvent* event) OVERRIDE {
650 if (delete_during_pre_handle_) 648 if (delete_during_pre_handle_)
651 delete event->target(); 649 delete event->target();
652 return ui::ER_UNHANDLED; 650 return ui::ER_UNHANDLED;
653 } 651 }
654 652
655 bool delete_during_pre_handle_; 653 bool delete_during_pre_handle_;
656 654
(...skipping 10 matching lines...) Expand all
667 665
668 void Reset(Window* window, bool delete_during_handle) { 666 void Reset(Window* window, bool delete_during_handle) {
669 window_ = window; 667 window_ = window;
670 delete_during_handle_ = delete_during_handle; 668 delete_during_handle_ = delete_during_handle;
671 got_event_ = false; 669 got_event_ = false;
672 } 670 }
673 bool got_event() const { return got_event_; } 671 bool got_event() const { return got_event_; }
674 672
675 private: 673 private:
676 // Overridden from WindowDelegate: 674 // Overridden from WindowDelegate:
677 virtual ui::EventResult OnKeyEvent(ui::KeyEvent* event) OVERRIDE { 675 virtual void OnKeyEvent(ui::KeyEvent* event) OVERRIDE {
678 if (delete_during_handle_) 676 if (delete_during_handle_)
679 delete window_; 677 delete window_;
680 got_event_ = true; 678 got_event_ = true;
681 return ui::ER_UNHANDLED;
682 } 679 }
683 680
684 virtual ui::EventResult OnMouseEvent(ui::MouseEvent* event) OVERRIDE { 681 virtual ui::EventResult OnMouseEvent(ui::MouseEvent* event) OVERRIDE {
685 if (delete_during_handle_) 682 if (delete_during_handle_)
686 delete window_; 683 delete window_;
687 got_event_ = true; 684 got_event_ = true;
688 return ui::ER_UNHANDLED; 685 return ui::ER_UNHANDLED;
689 } 686 }
690 687
691 Window* window_; 688 Window* window_;
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
768 TEST_F(RootWindowTest, GestureRecognizerResetsTargetWhenParentHides) { 765 TEST_F(RootWindowTest, GestureRecognizerResetsTargetWhenParentHides) {
769 scoped_ptr<Window> w1(CreateWindow(1, root_window(), NULL)); 766 scoped_ptr<Window> w1(CreateWindow(1, root_window(), NULL));
770 DetachesParentOnTapDelegate delegate; 767 DetachesParentOnTapDelegate delegate;
771 scoped_ptr<Window> parent(CreateWindow(22, w1.get(), NULL)); 768 scoped_ptr<Window> parent(CreateWindow(22, w1.get(), NULL));
772 Window* child = CreateWindow(11, parent.get(), &delegate); 769 Window* child = CreateWindow(11, parent.get(), &delegate);
773 test::EventGenerator generator(root_window(), child); 770 test::EventGenerator generator(root_window(), child);
774 generator.GestureTapAt(gfx::Point(40, 40)); 771 generator.GestureTapAt(gfx::Point(40, 40));
775 } 772 }
776 773
777 } // namespace aura 774 } // namespace aura
OLDNEW
« no previous file with comments | « content/browser/web_contents/web_contents_view_aura.cc ('k') | ui/aura/test/test_event_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698