chrome/browser/extensions/api/input/input.cc - Issue 11570012: events: Update key-event handlers to not return EventResult.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/input/input.cc

Issue 11570012: events: Update key-event handlers to not return EventResult. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tot-merge-for-landing Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/input/input.cc

diff --git a/chrome/browser/extensions/api/input/input.cc b/chrome/browser/extensions/api/input/input.cc

index e25f580a91769b0408b55a8ea944894a15b1d6ff..43c0e30145b200e16efae4e13cb4c22cfc0602fd 100644

--- a/chrome/browser/extensions/api/input/input.cc

+++ b/chrome/browser/extensions/api/input/input.cc

@@ -122,9 +122,12 @@ bool SendKeyboardEventInputFunction::RunImpl() {

views::InputMethod* ime = widget->GetInputMethod();

if (ime) {

ime->DispatchKeyEvent(event);

- } else if (!widget->OnKeyEvent(event)) {

- error_ = kKeyEventUnprocessedError;

- return false;

+ } else {

+ widget->OnKeyEvent(&event);

+ if (event.handled()) {

+ error_ = kKeyEventUnprocessedError;

+ return false;

+ }

}

return true;