Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: content/child/push_messaging/push_provider.cc

Issue 1154303003: Move push endpoint concatenation up to the browser process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/push_messaging/push_provider.h ('k') | content/common/push_messaging_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/push_messaging/push_provider.cc
diff --git a/content/child/push_messaging/push_provider.cc b/content/child/push_messaging/push_provider.cc
index e326d137581cc64cd72c5f9cd778ce35253a4666..927da07baa35fd30984f680cc51c482e0198c973 100644
--- a/content/child/push_messaging/push_provider.cc
+++ b/content/child/push_messaging/push_provider.cc
@@ -148,17 +148,14 @@ bool PushProvider::OnMessageReceived(const IPC::Message& message) {
void PushProvider::OnSubscribeFromWorkerSuccess(
int request_id,
- const GURL& endpoint,
- const std::string& subscription_id) {
+ const GURL& endpoint) {
blink::WebPushSubscriptionCallbacks* callbacks =
subscription_callbacks_.Lookup(request_id);
if (!callbacks)
return;
scoped_ptr<blink::WebPushSubscription> subscription(
- new blink::WebPushSubscription(
- blink::WebString::fromUTF8(endpoint.spec()),
- blink::WebString::fromUTF8(subscription_id)));
+ new blink::WebPushSubscription(endpoint));
callbacks->onSuccess(subscription.release());
subscription_callbacks_.Remove(request_id);
@@ -208,17 +205,14 @@ void PushProvider::OnUnsubscribeError(
void PushProvider::OnGetRegistrationSuccess(
int request_id,
- const GURL& endpoint,
- const std::string& registration_id) {
+ const GURL& endpoint) {
blink::WebPushSubscriptionCallbacks* callbacks =
subscription_callbacks_.Lookup(request_id);
if (!callbacks)
return;
scoped_ptr<blink::WebPushSubscription> subscription(
- new blink::WebPushSubscription(
- blink::WebString::fromUTF8(endpoint.spec()),
- blink::WebString::fromUTF8(registration_id)));
+ new blink::WebPushSubscription(endpoint));
callbacks->onSuccess(subscription.release());
subscription_callbacks_.Remove(request_id);
« no previous file with comments | « content/child/push_messaging/push_provider.h ('k') | content/common/push_messaging_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698