content/child/push_messaging/push_provider.h - Issue 1154303003: Move push endpoint concatenation up to the browser process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/push_messaging/push_provider.h

Issue 1154303003: Move push endpoint concatenation up to the browser process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/push_messaging/push_messaging_message_filter.cc ('k') | content/child/push_messaging/push_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/push_messaging/push_provider.h

diff --git a/content/child/push_messaging/push_provider.h b/content/child/push_messaging/push_provider.h

index efd726167aaab262485bd0be30a24684abb8cdd7..b47eea8076e751e224bd594b66c4bc71dac8cc13 100644

--- a/content/child/push_messaging/push_provider.h

+++ b/content/child/push_messaging/push_provider.h

@@ -64,8 +64,7 @@ class PushProvider : public blink::WebPushProvider,

// IPC message handlers.

void OnSubscribeFromWorkerSuccess(int request_id,

- const GURL& endpoint,

- const std::string& subscription_id);

+ const GURL& endpoint);

void OnSubscribeFromWorkerError(int request_id,

PushRegistrationStatus status);

void OnUnsubscribeSuccess(int request_id, bool did_unsubscribe);

@@ -73,8 +72,7 @@ class PushProvider : public blink::WebPushProvider,

blink::WebPushError::ErrorType error_type,

const std::string& error_message);

void OnGetRegistrationSuccess(int request_id,

- const GURL& endpoint,

- const std::string& registration_id);

+ const GURL& endpoint);

void OnGetRegistrationError(int request_id, PushGetRegistrationStatus status);

void OnGetPermissionStatusSuccess(int request_id,

blink::WebPushPermissionStatus status);

« no previous file with comments | « content/browser/push_messaging/push_messaging_message_filter.cc ('k') | content/child/push_messaging/push_provider.cc » ('j') | no next file with comments »