content/renderer/push_messaging/push_messaging_dispatcher.h - Issue 1154303003: Move push endpoint concatenation up to the browser process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/push_messaging/push_messaging_dispatcher.h

Issue 1154303003: Move push endpoint concatenation up to the browser process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/push_messaging/push_messaging_dispatcher.h

diff --git a/content/renderer/push_messaging/push_messaging_dispatcher.h b/content/renderer/push_messaging/push_messaging_dispatcher.h

index 981569a23b9033b44515b4bd0d6303a7f44fd266..18bf060f416c2a388456fbfa6fe80b3e0a41efdf 100644

--- a/content/renderer/push_messaging/push_messaging_dispatcher.h

+++ b/content/renderer/push_messaging/push_messaging_dispatcher.h

@@ -51,8 +51,7 @@ class PushMessagingDispatcher : public RenderFrameObserver,

const Manifest& manifest);

void OnSubscribeFromDocumentSuccess(int32_t request_id,

- const GURL& endpoint,

- const std::string& subscription_id);

+ const GURL& endpoint);

void OnSubscribeFromDocumentError(int32_t request_id,

PushRegistrationStatus status);

« no previous file with comments | « content/common/push_messaging_messages.h ('k') | content/renderer/push_messaging/push_messaging_dispatcher.cc » ('j') | no next file with comments »