content/browser/plugin_browsertest.cc - Issue 1153813003: Add user_gesture param to WebContentsDelegate::ActivateContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/plugin_browsertest.cc

Issue 1153813003: Add user_gesture param to WebContentsDelegate::ActivateContents Base URL: https://chromium.googlesource.com/chromium/src.git@ug1_WebContentsImpl_Activate

Patch Set: Update callers Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/web_contents_delegate_android/web_contents_delegate_android.h ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/plugin_browsertest.cc

diff --git a/content/browser/plugin_browsertest.cc b/content/browser/plugin_browsertest.cc

index c37f7b702e67e5adacc25511d2b1bd628b2ccf19..47453975e8b24c423f2ca8ef34bcbeee9edb63db 100644

--- a/content/browser/plugin_browsertest.cc

+++ b/content/browser/plugin_browsertest.cc

@@ -439,7 +439,7 @@ IN_PROC_BROWSER_TEST_F(PluginTest, DISABLED_PluginConvertPointTest) {

// TODO: is this code still needed? It was here when it used to run in

// browser_tests.

//static_cast<WebContentsDelegate*>(shell())->

- // ActivateContents(shell()->web_contents());

+ // ActivateContents(shell()->web_contents(), false /* user_gesture */);

EXPECT_EQ(expected_title, title_watcher.WaitAndGetTitle());

}

#endif