chrome/browser/task_manager/task_manager.cc - Issue 1153813003: Add user_gesture param to WebContentsDelegate::ActivateContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager/task_manager.cc

Issue 1153813003: Add user_gesture param to WebContentsDelegate::ActivateContents Base URL: https://chromium.googlesource.com/chromium/src.git@ug1_WebContentsImpl_Activate

Patch Set: Update callers Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/print_preview_dialog_controller.cc ('k') | chrome/browser/ui/android/javascript_app_modal_dialog_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_manager/task_manager.cc

diff --git a/chrome/browser/task_manager/task_manager.cc b/chrome/browser/task_manager/task_manager.cc

index ec32624a1efc1f63033bf5e682f2e064c0c2505b..45c30d59cee9703e72d982031d392fcc018eee3a 100644

--- a/chrome/browser/task_manager/task_manager.cc

+++ b/chrome/browser/task_manager/task_manager.cc

@@ -1495,8 +1495,10 @@ void TaskManager::ActivateProcess(int index) {

// (i.e. refers to the Browser process or a plugin), GetWebContents will

// return NULL.

WebContents* chosen_web_contents = model_->GetResourceWebContents(index);

- if (chosen_web_contents && chosen_web_contents->GetDelegate())

- chosen_web_contents->GetDelegate()->ActivateContents(chosen_web_contents);

+ if (chosen_web_contents && chosen_web_contents->GetDelegate()) {

+ chosen_web_contents->GetDelegate()->ActivateContents(

+ chosen_web_contents, true /* user_gesture */);

+ }

}

void TaskManager::AddResource(Resource* resource) {