chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm - Issue 1153813003: Add user_gesture param to WebContentsDelegate::ActivateContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm

Issue 1153813003: Add user_gesture param to WebContentsDelegate::ActivateContents Base URL: https://chromium.googlesource.com/chromium/src.git@ug1_WebContentsImpl_Activate

Patch Set: Update callers Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm b/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm

index 73ee1c649fa21b755a47df3dff9bd7da90a3698f..8278c13c00c1df02d50c0920118f9ed060b967d5 100644

--- a/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm

+++ b/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm

@@ -462,8 +462,9 @@ class ChromeJavaScriptNativeDialogCocoaFactory

app_modal::JavaScriptAppModalDialog* dialog) override {

app_modal::NativeAppModalDialog* d =

new JavaScriptAppModalDialogCocoa(dialog);

+ // TODO(johnme): Can we sometimes be certain this was for a user gesture?

dialog->web_contents()->GetDelegate()->ActivateContents(

- dialog->web_contents());

+ dialog->web_contents(), false /* user_gesture */);

return d;

}

« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/panels/panel_host.h » ('j') | no next file with comments »