Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5248)

Unified Diff: chrome/browser/ui/webui/options/sync_setup_handler.cc

Issue 1153813003: Add user_gesture param to WebContentsDelegate::ActivateContents Base URL: https://chromium.googlesource.com/chromium/src.git@ug1_WebContentsImpl_Activate
Patch Set: Update callers Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/sync_setup_handler.cc
diff --git a/chrome/browser/ui/webui/options/sync_setup_handler.cc b/chrome/browser/ui/webui/options/sync_setup_handler.cc
index bc9e41f2b6f554220eec7c402a60a15ca96f298b..238888b4e7612210e1a95c0ddb7b8c48fe02222f 100644
--- a/chrome/browser/ui/webui/options/sync_setup_handler.cc
+++ b/chrome/browser/ui/webui/options/sync_setup_handler.cc
@@ -770,7 +770,9 @@ void SyncSetupHandler::OpenConfigureSync() {
void SyncSetupHandler::FocusUI() {
DCHECK(IsActiveLogin());
WebContents* web_contents = web_ui()->GetWebContents();
- web_contents->GetDelegate()->ActivateContents(web_contents);
+ // TODO(johnme): Can we sometimes be certain this was for a user gesture?
+ web_contents->GetDelegate()->ActivateContents(web_contents,
+ false /* user_gesture */);
}
void SyncSetupHandler::CloseUI() {

Powered by Google App Engine
This is Rietveld 408576698