chrome/browser/ui/blocked_content/app_modal_dialog_helper.cc - Issue 1153813003: Add user_gesture param to WebContentsDelegate::ActivateContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/blocked_content/app_modal_dialog_helper.cc

Issue 1153813003: Add user_gesture param to WebContentsDelegate::ActivateContents Base URL: https://chromium.googlesource.com/chromium/src.git@ug1_WebContentsImpl_Activate

Patch Set: Update callers Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/blocked_content/app_modal_dialog_helper.cc

diff --git a/chrome/browser/ui/blocked_content/app_modal_dialog_helper.cc b/chrome/browser/ui/blocked_content/app_modal_dialog_helper.cc

index fea3ec37b5699dedf8f3e2af672772334c2cb5e0..16683981850c88128b18ca01bd7e4a1ea9b49acf 100644

--- a/chrome/browser/ui/blocked_content/app_modal_dialog_helper.cc

+++ b/chrome/browser/ui/blocked_content/app_modal_dialog_helper.cc

@@ -34,8 +34,9 @@ AppModalDialogHelper::AppModalDialogHelper(content::WebContents* dialog_host)

}

AppModalDialogHelper::~AppModalDialogHelper() {

+ // TODO(johnme): Can we sometimes be certain this was for a user gesture?

if (popup_)

- popup_->GetDelegate()->ActivateContents(popup_);

+ popup_->GetDelegate()->ActivateContents(popup_, false /* user_gesture */);

}

void AppModalDialogHelper::WebContentsDestroyed() {

« no previous file with comments | « chrome/browser/ui/android/javascript_app_modal_dialog_android.cc ('k') | chrome/browser/ui/browser.h » ('j') | no next file with comments »