Chromium Code Reviews
Help | Chromium Project | Sign in
(742)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 11301006: automate more GL state handling (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 4 months ago by greggman
Modified:
1 year, 4 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews_chromium.org, apatrick_chromium
Visibility:
Public.

Description

automate more GL state handling

BUG=155557
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164798

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1638 lines, -807 lines) Lint Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 36 chunks +744 lines, -198 lines 0 comments ? errors Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 2 chunks +4 lines, -4 lines 0 comments ? errors Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 5 chunks +48 lines, -41 lines 0 comments ? errors Download
M gpu/command_buffer/service/context_state.h View 1 2 3 chunks +9 lines, -72 lines 0 comments ? errors Download
M gpu/command_buffer/service/context_state.cc View 1 2 2 chunks +20 lines, -62 lines 0 comments ? errors Download
A gpu/command_buffer/service/context_state_autogen.h View 1 chunk +81 lines, -0 lines 0 comments ? errors Download
A gpu/command_buffer/service/context_state_impl_autogen.h View 1 2 1 chunk +130 lines, -0 lines 0 comments ? errors Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 11 chunks +15 lines, -270 lines 0 comments ? errors Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 2 10 chunks +405 lines, -10 lines 0 comments 0 errors Download
A gpu/command_buffer/service/gles2_cmd_decoder_unittest_0_autogen.h View 1 chunk +99 lines, -0 lines 0 comments 0 errors Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h View 2 chunks +4 lines, -4 lines 0 comments ? errors Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 2 chunks +3 lines, -3 lines 0 comments ? errors Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 chunk +4 lines, -0 lines 0 comments ? errors Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 4 chunks +21 lines, -102 lines 0 comments ? errors Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 5 chunks +48 lines, -41 lines 0 comments ? errors Download
M gpu/command_buffer_service.gypi View 1 chunk +2 lines, -0 lines 0 comments ? errors Download
M gpu/gpu.gyp View 1 chunk +1 line, -0 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 5
greggman
Hey Al, PTAL I figured given the number of places you have to remember to ...
1 year, 4 months ago #1
apatrick_chromium
lgtm https://codereview.chromium.org/11301006/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/11301006/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode980 gpu/command_buffer/service/gles2_cmd_decoder.cc:980: // Same as GetHealper except for auto-generated state. ...
1 year, 4 months ago #2
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/11301006/8003
1 year, 4 months ago #3
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/11301006/1038
1 year, 4 months ago #4
I haz the power (commit-bot)
1 year, 4 months ago #5 
Change committed as 164798
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1239:6f3a9f6bdaa8