Issue 11275296: Move shadow code to views\corewm

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+188 lines, -1778 lines)			Patch
M	ash/ash.gyp	View	1 2 3	3 chunks	+0 lines, -10 lines	0 comments	Download
M	ash/dip_unittest.cc	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ash/drag_drop/drag_image_view.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ash/shell.h	View	1 2 3	4 chunks	+3 lines, -3 lines	0 comments	Download
M	ash/shell.cc	View	1 2 3	3 chunks	+3 lines, -2 lines	0 comments	Download
M	ash/shell/window_type_launcher.cc	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download
D	ash/wm/image_grid.h	View	1 2 3	1 chunk	+0 lines, -218 lines	0 comments	Download
D	ash/wm/image_grid.cc	View	1 2 3	1 chunk	+0 lines, -284 lines	0 comments	Download
D	ash/wm/image_grid_unittest.cc	View	1 2 3	1 chunk	+0 lines, -342 lines	0 comments	Download
M	ash/wm/resize_shadow.h	View	1 2 3	2 chunks	+6 lines, -3 lines	0 comments	Download
M	ash/wm/resize_shadow.cc	View	1 2 3	3 chunks	+2 lines, -2 lines	0 comments	Download
D	ash/wm/shadow.h	View	1 2 3	1 chunk	+0 lines, -84 lines	0 comments	Download
D	ash/wm/shadow.cc	View	1 2 3	1 chunk	+0 lines, -176 lines	0 comments	Download
D	ash/wm/shadow_controller.h	View	1 2 3	1 chunk	+0 lines, -104 lines	0 comments	Download
D	ash/wm/shadow_controller.cc	View	1 2 3	1 chunk	+0 lines, -169 lines	0 comments	Download
D	ash/wm/shadow_controller_unittest.cc	View	1 2 3	1 chunk	+0 lines, -191 lines	0 comments	Download
D	ash/wm/shadow_types.h	View	1 2 3	1 chunk	+0 lines, -31 lines	0 comments	Download
D	ash/wm/shadow_types.cc	View	1 2 3	1 chunk	+0 lines, -22 lines	0 comments	Download
M	ash/wm/window_properties.h	View	1 2 3	2 chunks	+0 lines, -5 lines	0 comments	Download
M	ash/wm/window_properties.cc	View	1 2 3	2 chunks	+0 lines, -3 lines	0 comments	Download
M	ash/wm/workspace/phantom_window_controller.cc	View	1 2 3	3 chunks	+3 lines, -2 lines	0 comments	Download
M	ui/aura/test/test_activation_client.h	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/aura/test/test_activation_client.cc	View	1 2 3	2 chunks	+9 lines, -1 line	0 comments	Download
A +	ui/views/corewm/image_grid.h	View	1 2 3	4 chunks	+10 lines, -10 lines	0 comments	Download
A +	ui/views/corewm/image_grid.cc	View	1 2 3	3 chunks	+5 lines, -5 lines	0 comments	Download
A +	ui/views/corewm/image_grid_unittest.cc	View	1 2 3	3 chunks	+7 lines, -9 lines	0 comments	Download
A +	ui/views/corewm/shadow.h	View		2 chunks	+9 lines, -9 lines	0 comments	Download
A +	ui/views/corewm/shadow.cc	View		4 chunks	+10 lines, -11 lines	0 comments	Download
A +	ui/views/corewm/shadow_controller.h	View		4 chunks	+13 lines, -10 lines	0 comments	Download
A +	ui/views/corewm/shadow_controller.cc	View		4 chunks	+12 lines, -15 lines	0 comments	Download
A +	ui/views/corewm/shadow_controller_unittest.cc	View	1 2	11 chunks	+51 lines, -31 lines	0 comments	Download
A +	ui/views/corewm/shadow_types.h	View		2 chunks	+15 lines, -10 lines	0 comments	Download
A +	ui/views/corewm/shadow_types.cc	View		2 chunks	+10 lines, -7 lines	0 comments	Download
M	ui/views/views.gyp	View	1 2 3	3 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

8 years, 1 month ago (2012-11-13 22:40:01 UTC) #2

LGTM if it compiles

https://codereview.chromium.org/11275296/diff/5002/ui/views/corewm/shadow_con...
File ui/views/corewm/shadow_controller_unittest.cc (right):

https://codereview.chromium.org/11275296/diff/5002/ui/views/corewm/shadow_con...
ui/views/corewm/shadow_controller_unittest.cc:10: #include
"ui/aura/test/aura_test_base.h"
nit: alphabetize

Expand Messages | Collapse Messages