Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 11266030: Use gfx:: Geometry types for the resource provider and layer updater classes. (Closed)

Created:
8 years, 1 month ago by danakj
Modified:
8 years, 1 month ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, feature-media-reviews_chromium.org, cc-bugs_chromium.org, darin-cc_chromium.org, backer, piman
Visibility:
Public.

Description

Use gfx:: Geometry types for the resource provider and layer updater classes. This depends on the gfx::Vector2d class from https://codereview.chromium.org/11269022/ Covered by existing tests, just changing data types. BUG=147395 R=enne Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165225

Patch Set 1 #

Patch Set 2 : Rebase and use gfx::Scale() #

Patch Set 3 : rebase-resource #

Patch Set 4 : rebase-resource #

Patch Set 5 : uint8 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -281 lines) Patch
M cc/bitmap_content_layer_updater.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M cc/bitmap_content_layer_updater.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M cc/bitmap_skpicture_content_layer_updater.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
cc/bitmap_skpicture_content_layer_updater.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M cc/caching_bitmap_content_layer_updater.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M cc/caching_bitmap_content_layer_updater.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M cc/content_layer.h View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M cc/content_layer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/content_layer_client.h View 1 chunk +6 lines, -3 lines 0 comments Download
M cc/content_layer_unittest.cc View 1 2 2 chunks +11 lines, -11 lines 0 comments Download
M cc/content_layer_updater.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M cc/content_layer_updater.cc View 1 2 4 chunks +9 lines, -10 lines 0 comments Download
M cc/gl_renderer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
cc/heads_up_display_layer_impl.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M cc/image_layer.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M cc/layer_painter.h View 1 chunk +6 lines, -4 lines 0 comments Download
M cc/layer_tree_host_common_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_tree_host_unittest.cc View 1 2 4 chunks +5 lines, -4 lines 0 comments Download
M cc/layer_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
cc/layer_updater.h View 1 2 3 chunks +7 lines, -4 lines 0 comments Download
M cc/prioritized_texture.h View 1 2 7 chunks +11 lines, -10 lines 0 comments Download
M cc/prioritized_texture.cc View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
cc/prioritized_texture_manager.h View 1 2 4 chunks +3 lines, -4 lines 0 comments Download
M cc/prioritized_texture_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/prioritized_texture_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/resource_provider.h View 1 2 3 8 chunks +14 lines, -10 lines 0 comments Download
cc/resource_provider.cc View 10 chunks +10 lines, -9 lines 0 comments Download
M cc/resource_provider_unittest.cc View 20 chunks +34 lines, -34 lines 0 comments Download
M cc/resource_update.h View 3 chunks +11 lines, -10 lines 0 comments Download
cc/resource_update.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M cc/resource_update_controller.cc View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M cc/resource_update_controller_unittest.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M cc/scrollbar_layer.cc View 1 2 3 chunks +5 lines, -6 lines 0 comments Download
M cc/skpicture_content_layer_updater.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
cc/skpicture_content_layer_updater.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M cc/software_renderer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/stubs/int_rect.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/test/tiled_layer_test_common.h View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M cc/test/tiled_layer_test_common.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M cc/texture.h View 1 chunk +6 lines, -6 lines 0 comments Download
M cc/texture.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/texture_uploader.h View 1 2 3 4 5 chunks +20 lines, -15 lines 0 comments Download
M cc/texture_uploader.cc View 1 2 3 4 10 chunks +34 lines, -34 lines 0 comments Download
M cc/texture_uploader_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M cc/tiled_layer.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M cc/tiled_layer_unittest.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M cc/video_layer_impl.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/compositor_bindings/web_content_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/compositor_bindings/web_content_layer_impl.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danakj
8 years, 1 month ago (2012-10-25 02:11:02 UTC) #1
enne (OOO)
lgtm
8 years, 1 month ago (2012-10-29 19:56:37 UTC) #2
commit-bot: I haz the power
8 years, 1 month ago (2012-10-31 20:12:39 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698