Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1116713002: Pull out shader-specific caps into GrShaderCaps and GrGLSLCaps (Closed)

Created:
5 years, 7 months ago by jvanverth1
Modified:
5 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Pull out shader-specific caps into GrShaderCaps and GrGLSLCaps BUG=skia: Committed: https://skia.googlesource.com/skia/+/e9c0fc616d2a1632c285885b9b656b68ca8d4f24

Patch Set 1 #

Patch Set 2 : Remove unnecessary destructor #

Patch Set 3 : Clean up some comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+478 lines, -328 lines) Patch
M include/gpu/GrFragmentProcessor.h View 1 chunk +1 line, -2 lines 0 comments Download
M include/gpu/GrXferProcessor.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrCoordTransform.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 10 chunks +84 lines, -67 lines 0 comments Download
M src/gpu/GrDrawTargetCaps.h View 1 2 5 chunks +68 lines, -41 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPrimitiveProcessor.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrStencilAndCoverPathRenderer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrXferProcessor.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.h View 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 1 2 7 chunks +64 lines, -25 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 8 chunks +215 lines, -147 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLPathRendering.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jvanverth1
5 years, 7 months ago (2015-04-29 17:09:11 UTC) #2
bsalomon
lgtm
5 years, 7 months ago (2015-04-29 18:11:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116713002/40001
5 years, 7 months ago (2015-04-29 18:14:29 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 18:18:10 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e9c0fc616d2a1632c285885b9b656b68ca8d4f24

Powered by Google App Engine
This is Rietveld 408576698