Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1104233004: DevTools: rebaseline inspector tests with poor expectations (2). (Closed)

Created:
5 years, 8 months ago by pfeldman
Modified:
5 years, 7 months ago
Reviewers:
alph
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: rebaseline inspector tests with poor expectations (2). BUG=441738, 464729, 308768, 475638 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194754

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments addressed #

Total comments: 2

Patch Set 3 : rebaselined #

Patch Set 4 : for landing #

Patch Set 5 : rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -94 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 4 chunks +0 lines, -10 lines 0 comments Download
M LayoutTests/http/tests/inspector/inspector-test.js View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/inspector/extensions/extensions-network-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/network/network-status-non-http.html View 3 chunks +11 lines, -15 lines 0 comments Download
M LayoutTests/inspector/network/network-status-non-http-expected.txt View 1 chunk +3 lines, -5 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/show-function-definition.html View 1 2 3 1 chunk +13 lines, -13 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/show-function-definition-expected.txt View 1 chunk +1 line, -5 lines 0 comments Download
M LayoutTests/inspector/tracing-test.js View 1 1 chunk +2 lines, -4 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-bound-function-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-injected-script-eval-expected.txt View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-receive-response-event-expected.txt View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/inspector/tracing/timeline-script-id.html View 1 2 chunks +7 lines, -6 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-script-id-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/inspector/tracing/timeline-script-tag-1.html View 1 2 3 1 chunk +4 lines, -16 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-script-tag-1-expected.txt View 1 2 3 1 chunk +2 lines, -12 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-timer-expected.txt View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/ScriptFunctionCall.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/core/v8/ScriptFunctionCall.cpp View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/V8Binding.cpp View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/inspector/InjectedScriptBase.cpp View 1 2 3 4 1 chunk +5 lines, -2 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModel.js View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 27 (13 generated)
pfeldman
5 years, 8 months ago (2015-04-27 18:00:21 UTC) #2
alph
https://codereview.chromium.org/1104233004/diff/1/LayoutTests/inspector/tracing/timeline-script-id-expected.txt File LayoutTests/inspector/tracing/timeline-script-id-expected.txt (right): https://codereview.chromium.org/1104233004/diff/1/LayoutTests/inspector/tracing/timeline-script-id-expected.txt#newcode6 LayoutTests/inspector/tracing/timeline-script-id-expected.txt:6: details.textContent for FunctionCall event: 'InjectedScript:1' Sorry, don't see what ...
5 years, 8 months ago (2015-04-27 18:10:43 UTC) #3
pfeldman
PTAL
5 years, 7 months ago (2015-04-29 09:17:21 UTC) #4
alph
lgtm https://codereview.chromium.org/1104233004/diff/20001/LayoutTests/inspector/tracing/timeline-script-id.html File LayoutTests/inspector/tracing/timeline-script-id.html (right): https://codereview.chromium.org/1104233004/diff/20001/LayoutTests/inspector/tracing/timeline-script-id.html#newcode42 LayoutTests/inspector/tracing/timeline-script-id.html:42: InspectorTest.addResult("detailsTextContent for " + record.type() + " event: ...
5 years, 7 months ago (2015-04-29 10:22:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104233004/20001
5 years, 7 months ago (2015-04-29 10:36:40 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/61173)
5 years, 7 months ago (2015-04-29 11:45:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104233004/40001
5 years, 7 months ago (2015-04-29 12:05:24 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/59831)
5 years, 7 months ago (2015-04-29 14:40:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104233004/60001
5 years, 7 months ago (2015-04-30 12:59:52 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/43536) mac_blink_rel on tryserver.blink (JOB_FAILED, ...
5 years, 7 months ago (2015-04-30 13:03:33 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104233004/60001
5 years, 7 months ago (2015-04-30 15:26:13 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/43554) mac_blink_rel on tryserver.blink (JOB_FAILED, ...
5 years, 7 months ago (2015-04-30 15:30:01 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104233004/80001
5 years, 7 months ago (2015-04-30 15:42:34 UTC) #26
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 17:27:45 UTC) #27
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194754

Powered by Google App Engine
This is Rietveld 408576698