LayoutTests/inspector/tracing/timeline-script-id.html - Issue 1104233004: DevTools: rebaseline inspector tests with poor expectations (2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/inspector/tracing/timeline-script-id.html

Issue 1104233004: DevTools: rebaseline inspector tests with poor expectations (2). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebaselined Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/tracing/timeline-receive-response-event-expected.txt ('k') | LayoutTests/inspector/tracing/timeline-script-id-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/inspector/tracing/timeline-script-id.html

diff --git a/LayoutTests/inspector/tracing/timeline-script-id.html b/LayoutTests/inspector/tracing/timeline-script-id.html

index 9754371542036609c47e15e377caaecd345e7436..de41e73ac1bffb8c0d22d73086b23058c7bd247c 100644

--- a/LayoutTests/inspector/tracing/timeline-script-id.html

+++ b/LayoutTests/inspector/tracing/timeline-script-id.html

@@ -23,9 +23,12 @@ function test()

var source = performActions.toString();

source += "\n//@ sourceURL=performActions.js";

- InspectorTest.evaluateInPage(source);

+ InspectorTest.evaluateInPage(source, startTimeline);

- InspectorTest.invokeAsyncWithTimeline("performActions", finish);

+ function startTimeline()

+ {

+ InspectorTest.invokeAsyncWithTimeline("performActions", finish);

+ }

var linkifier = new WebInspector.Linkifier();

@@ -36,12 +39,10 @@ function test()

return;

var detailsText = WebInspector.TimelineUIUtils.buildDetailsTextForTraceEvent(record.traceEvent(), InspectorTest.timelineModel().target());

- if (detailsText)

- InspectorTest.addResult("detailsTextContent for " + record.type() + " event: '" + detailsText + "'");

+ InspectorTest.addResult("detailsTextContent for " + record.type() + " event: '" + detailsText.replace(/VM[\d]+/, "VM") + "'");

var details = WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent(record.traceEvent(), InspectorTest.timelineModel().target(), linkifier);

- if (details)

- InspectorTest.addResult("details.textContent for " + record.type() + " event: '" + details.textContent + "'");

+ InspectorTest.addResult("details.textContent for " + record.type() + " event: '" + details.textContent.replace(/VM[\d]+/, "VM") + "'");

}

function finish()