Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1264)

Unified Diff: Source/devtools/front_end/timeline/TimelineModel.js

Issue 1104233004: DevTools: rebaseline inspector tests with poor expectations (2). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebaselined Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InjectedScriptBase.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/timeline/TimelineModel.js
diff --git a/Source/devtools/front_end/timeline/TimelineModel.js b/Source/devtools/front_end/timeline/TimelineModel.js
index 214926e89fcaf28768a0cfe802b084de2f8e1678..31c26d2cd0b45d7c079538a767e5481093c2c6c6 100644
--- a/Source/devtools/front_end/timeline/TimelineModel.js
+++ b/Source/devtools/front_end/timeline/TimelineModel.js
@@ -655,8 +655,9 @@ WebInspector.TimelineModel.prototype = {
/**
* @param {string} categories
* @param {boolean=} enableJSSampling
+ * @param {function(?string)=} callback
*/
- _startRecordingWithCategories: function(categories, enableJSSampling)
+ _startRecordingWithCategories: function(categories, enableJSSampling, callback)
{
if (!this._targets.length)
return;
@@ -666,7 +667,7 @@ WebInspector.TimelineModel.prototype = {
var samplingFrequencyHz = WebInspector.moduleSetting("highResolutionCpuProfiling").get() ? 10000 : 1000;
var options = "sampling-frequency=" + samplingFrequencyHz;
var tracingManager = this._targets[0].tracingManager;
- profilingStartedPromise.then(tracingManager.start.bind(tracingManager, this, categories, options, undefined));
+ profilingStartedPromise.then(tracingManager.start.bind(tracingManager, this, categories, options, callback));
},
/**
« no previous file with comments | « Source/core/inspector/InjectedScriptBase.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698