LayoutTests/inspector/network/network-status-non-http.html - Issue 1104233004: DevTools: rebaseline inspector tests with poor expectations (2).

Side by Side Diff: LayoutTests/inspector/network/network-status-non-http.html

Issue 1104233004: DevTools: rebaseline inspector tests with poor expectations (2). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebaselined Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/inspector/extensions/extensions-network-expected.txt ('k') | LayoutTests/inspector/network/network-status-non-http-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../../http/tests/inspector/inspector-test.js"></script>	3 <script src="../../http/tests/inspector/inspector-test.js"></script>

	4 <script src="../../http/tests/inspector/network-test.js"></script>

4 <script>	5 <script>

5 function test() {	6 function test()

	7 {

6 var requestsToWatch = /\/network-test\.js$\|\/non-existent-file.js$\|^data:app lication\/javascript,\|/;	8 var requestsToWatch = /\/network-test\.js$\|\/non-existent-file.js$\|^data:app lication\/javascript,\|/;

7 var seenRequests = 0;	9 var seenRequests = 0;

8	10

9 function dumpRequests()	11 function dumpRequests()

10 {	12 {

11 var logView = WebInspector.panels.network._networkLogView;	13 var logView = WebInspector.panels.network._networkLogView;

12 logView.refresh();	14 logView.refresh();

13 var dataGrid = logView.element.querySelector("table.data");	15 var dataGrid = logView.element.querySelector("table.data");

14 var urls = document.evaluate("//tbody/tr/td[position()=1]/@title", dataG rid, null, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null);	16 var urls = document.evaluate("//tbody/tr/td[position()=1]/@title", dataG rid, null, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null);

15 var outputStrings = [];	17 var outputStrings = [];

16	18

17 for (var i = 0; i < urls.snapshotLength; ++i) {	19 for (var request of WebInspector.targetManager.mainTarget().networkLog._ requests) {

18 var url = urls.snapshotItem(i).value;	20 var line = request.displayName + ":" + request.statusCode + " " + re quest.statusText

19 if (requestsToWatch.test(url)) {	21 if (request.failed)

20 var urlFragment = /^data:/.test(url) ? url.replace(/,.$/, "") : url.replace(/.\//, "");	22 line += "(failed)";

21 var status = document.evaluate("ancestor::tr/td[position()=3]", urls.snapshotItem(i), null, XPathResult.STRING_TYPE, null);	23 else if (request.finished)

22 var outputStatus = status.stringValue;	24 line += "Finished";

23 // Truncate the status string on failure, since the description following "(failed)" is platform-dependent.	25 InspectorTest.addResult(line);

24 if (outputStatus.startsWith("(failed)"))

25 outputStatus = "(failed)";

26 outputStrings.push(urlFragment + ": " + outputStatus);

27 }

28 }	26 }

29 outputStrings.sort();

30 InspectorTest.addObject(outputStrings);

31 InspectorTest.completeTest();	27 InspectorTest.completeTest();

32 }	28 }

33	29

34 function onRequestFinished(request)	30 function onRequestFinished(request)

35 {	31 {

36 if (!requestsToWatch.test(request.url))	32 if (!requestsToWatch.test(request.url))

37 return;	33 return;

38 if (++seenRequests === 3)	34 if (++seenRequests === 3)

39 dumpRequests();	35 setTimeout(dumpRequests);

40 }	36 }

41	37

42 InspectorTest.networkManager.addEventListener(WebInspector.NetworkManager.Ev entTypes.RequestFinished, onRequestFinished);	38 InspectorTest.networkManager.addEventListener(WebInspector.NetworkManager.Ev entTypes.RequestFinished, onRequestFinished);

43 InspectorTest.recordNetwork();	39 InspectorTest.recordNetwork();

44 InspectorTest.evaluateInPage("loadResources()");	40 InspectorTest.evaluateInPage("loadResources()");

45 }	41 }

46	42

47 function addScriptElement(src)	43 function addScriptElement(src)

48 {	44 {

49 var element = document.createElement("script");	45 var element = document.createElement("script");

50 element.src = src;	46 element.src = src;

51 document.body.appendChild(element);	47 document.body.appendChild(element);

52 }	48 }

53	49

54 function loadResources()	50 function loadResources()

55 {	51 {

56 addScriptElement("../../http/tests/inspector/network-test.js");	52 addScriptElement("../../http/tests/inspector/network-test.js");

57 addScriptElement("non-existent-file.js");	53 addScriptElement("non-existent-file.js");

58	54

59 // Test that data-url doesn't appear in network panel.	55 // Test that data-url doesn't appear in network panel.

60 addScriptElement("data:application/javascript,var x = 0;");	56 addScriptElement("data:application/javascript,var x = 0;");

61 }	57 }

62	58

63 </script>	59 </script>

64 </head>	60 </head>

65 <body onload="runTest()">	61 <body onload="runTest()">

66 </body>	62 </body>

67 </html>	63 </html>

OLD	NEW