Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: Source/bindings/core/v8/V8Binding.cpp

Issue 1104233004: DevTools: rebaseline inspector tests with poor expectations (2). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebaselined Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptFunctionCall.cpp ('k') | Source/core/inspector/InjectedScriptBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8Binding.cpp
diff --git a/Source/bindings/core/v8/V8Binding.cpp b/Source/bindings/core/v8/V8Binding.cpp
index 6f80a511074a81b9c9c1b27aad69dc1b68684142..10d5ac38f7856944db9fa912f243994c56892492 100644
--- a/Source/bindings/core/v8/V8Binding.cpp
+++ b/Source/bindings/core/v8/V8Binding.cpp
@@ -940,6 +940,7 @@ void DevToolsFunctionInfo::ensureInitialized() const
if (m_function.IsEmpty())
return;
+ v8::HandleScope scope(m_function->GetIsolate());
v8::Local<v8::Function> originalFunction = getBoundFunction(m_function);
m_scriptId = originalFunction->ScriptId();
v8::ScriptOrigin origin = originalFunction->GetScriptOrigin();
@@ -950,7 +951,7 @@ void DevToolsFunctionInfo::ensureInitialized() const
m_lineNumber = originalFunction->GetScriptLineNumber() + 1;
}
if (m_resourceName.isEmpty()) {
- m_resourceName = "undefined";
+ m_resourceName = "";
m_lineNumber = 1;
}
« no previous file with comments | « Source/bindings/core/v8/ScriptFunctionCall.cpp ('k') | Source/core/inspector/InjectedScriptBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698