LayoutTests/inspector/tracing-test.js - Issue 1104233004: DevTools: rebaseline inspector tests with poor expectations (2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/inspector/tracing-test.js

Issue 1104233004: DevTools: rebaseline inspector tests with poor expectations (2). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebaselined Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/sources/debugger/show-function-definition-expected.txt ('k') | LayoutTests/inspector/tracing/timeline-bound-function-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/inspector/tracing-test.js

diff --git a/LayoutTests/inspector/tracing-test.js b/LayoutTests/inspector/tracing-test.js

index 5108bf580ca4b6d3eabaf321f77598454a863fa3..5eb897ec8e0a66bc0560a50f1efbfa670d49b6dc 100644

--- a/LayoutTests/inspector/tracing-test.js

+++ b/LayoutTests/inspector/tracing-test.js

@@ -21,15 +21,13 @@ InspectorTest.tracingTimelineModel = function()

InspectorTest.invokeWithTracing = function(functionName, callback, additionalCategories, enableJSSampling)

{

- InspectorTest.tracingTimelineModel().addEventListener(WebInspector.TimelineModel.Events.RecordingStarted, onTracingStarted, this);

var categories = "-*,disabled-by-default-devtools.timeline*";

if (additionalCategories)

categories += "," + additionalCategories;

- InspectorTest.tracingTimelineModel()._startRecordingWithCategories(categories, enableJSSampling);

+ InspectorTest.tracingTimelineModel()._startRecordingWithCategories(categories, enableJSSampling, tracingStarted);

- function onTracingStarted(event)

+ function tracingStarted()

{

- InspectorTest.tracingTimelineModel().removeEventListener(WebInspector.TimelineModel.Events.RecordingStarted, onTracingStarted, this);

InspectorTest.invokePageFunctionAsync(functionName, onPageActionsDone);

}