Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1102733002: Remove most occurences of PrefRegistrySyncable::UNSYNCABLE_PREF (Closed)

Created:
5 years, 8 months ago by raymes
Modified:
5 years, 8 months ago
CC:
chromium-reviews, asanka, vandebo (ex-Chrome), je_julie(Not used), felt, yusukes+watch_chromium.org, tapted, posciak+watch_chromium.org, nektar+watch_chromium.org, vabr+watchlist_chromium.org, maxbogue+watch_chromium.org, browser-components-watch_chromium.org, skanuj+watch_chromium.org, noyau+watch_chromium.org, dmazzoni+watch_chromium.org, pvalenzuela+watch_chromium.org, sadrul, markusheintz_, aandrey+blink_chromium.org, stevenjb+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, Matt Giuca, mlamouri+watch-geolocation_chromium.org, tommycli, aboxhall+watch_chromium.org, dhollowa+watch_chromium.org, dzhioev+watch_chromium.org, jam, plaree+watch_chromium.org, nona+watch_chromium.org, rlp+watch_chromium.org, rouslan+autofillwatch_chromium.org, devtools-reviews_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, maniscalco+watch_chromium.org, johnme+watch_chromium.org, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, zea+watch_chromium.org, Greg Billock, derat+watch_chromium.org, mvanouwerkerk+watch_chromium.org, mlamouri+watch-notifications_chromium.org, dougw+watch_chromium.org, rouslan+spellwatch_chromium.org, yuzo+watch_chromium.org, dkrahn+watch_chromium.org, feature-media-reviews_chromium.org, samarth+watch_chromium.org, jfweitz+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, Michael van Ouwerkerk, gcasto+watchlist_chromium.org, Jered, mkwst+watchlist-passwords_chromium.org, kalyank, plundblad+watch_chromium.org, Lei Zhang, tfarina, donnd+watch_chromium.org, shuchen+watch_chromium.org, mcasas+watch_chromium.org, yurys, asvitkine+watch_chromium.org, benjhayden+dwatch_chromium.org, David Black, davemoore+watch_chromium.org, dtseng+watch_chromium.org, kmadhusu+watch_chromium.org, peter+watch_chromium.org, James Su, wjia+watch_chromium.org, pfeldman, estade+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@prefs-add-reg-funcs
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove most occurences of PrefRegistrySyncable::UNSYNCABLE_PREF Now that we have added PrefRegistry registration functions that do not need to accept a flags argument, passing PrefRegistrySyncable::UNSYNCABLE_PREF is redundant and we can remove it altogether. Ran the following command: for x in $(git ls-files | grep -E "\.(cc|h|mm)$") ; do perl -0777 -i -pe 's/,[ \n]*(user_prefs::)+PrefRegistrySyncable::UNSYNCABLE_PREF//igs' $x ; done && git cl format There are still some occurences that need to be manually fixed. BUG=476800 Committed: https://crrev.com/aa60872e346eaf354bb15dbd698546b1bdddd132 Cr-Commit-Position: refs/heads/master@{#326993}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+576 lines, -1602 lines) Patch
M chrome/browser/accessibility/animation_policy_prefs.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/accessibility/invert_bubble_prefs.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/android/bookmarks/partner_bookmarks_shim.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/android/new_tab_page_prefs.cc View 1 chunk +6 lines, -22 lines 0 comments Download
M chrome/browser/apps/drive/drive_app_mapping.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/apps/shortcut_manager.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/background/background_contents_service_factory.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model_factory.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +3 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/customization/customization_document.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/registry.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_syncer.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/chromeos/login/saml/saml_offline_signin_limiter.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/users/multi_profile_user_controller.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/net/proxy_config_handler.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/policy/policy_cert_service_factory.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/chromeos/power/power_prefs.cc View 3 chunks +31 lines, -95 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 12 chunks +28 lines, -86 lines 0 comments Download
M chrome/browser/component_updater/sw_reporter_installer_win.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry.cc View 1 chunk +5 lines, -12 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 chunk +11 lines, -28 lines 0 comments Download
M chrome/browser/download/download_prefs.cc View 1 chunk +9 lines, -24 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_log.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/preference/preference_api_prefs_unittest.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/extensions/default_apps.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/extensions/extension_management.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/launch_util.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/first_run/first_run.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/font_family_cache_unittest.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context_factory.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/google/google_url_tracker_factory.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M chrome/browser/media/media_capture_devices_dispatcher.cc View 1 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/browser/media/media_device_id_salt.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/media/media_stream_devices_controller.cc View 1 1 chunk +4 lines, -10 lines 0 comments Download
M chrome/browser/media/protected_media_identifier_permission_context_factory.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_preferences.cc View 1 chunk +5 lines, -10 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/net/http_server_properties_manager_factory.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/net/net_pref_observer.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/net/predictor.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/net/pref_proxy_config_tracker_impl.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/notifications/extension_welcome_notification.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M chrome/browser/password_manager/password_store_factory.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/pepper_flash_settings_manager.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M chrome/browser/plugins/plugin_prefs_factory.cc View 1 chunk +9 lines, -23 lines 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_factory.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/prefs/incognito_mode_prefs.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/prefs/prefs_syncable_service_unittest.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager_unittest.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M chrome/browser/prefs/session_startup_pref.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M chrome/browser/prefs/session_startup_pref_unittest.cc View 5 chunks +6 lines, -24 lines 0 comments Download
M chrome/browser/prefs/tracked/dictionary_hash_store_contents.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/prefs/tracked/pref_hash_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M chrome/browser/profile_resetter/automatic_profile_resetter_factory.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/profile_resetter/automatic_profile_resetter_unittest.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/profiles/chrome_version_service.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/profiles/gaia_info_update_service_factory.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile.cc View 1 2 chunks +30 lines, -91 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 3 chunks +13 lines, -52 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_application_id.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_service_impl.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/renderer_host/pepper/device_id_fetcher.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/search/hotword_service_factory.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_factory.cc View 1 chunk +33 lines, -70 lines 0 comments Download
M chrome/browser/signin/about_signin_internals_factory.cc View 1 2 chunks +3 lines, -12 lines 0 comments Download
M chrome/browser/signin/account_tracker_service_factory.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.cc View 1 chunk +4 lines, -12 lines 0 comments Download
M chrome/browser/signin/local_auth.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/signin/signin_manager_factory.cc View 1 chunk +16 lines, -40 lines 0 comments Download
M chrome/browser/signin/signin_promo.cc View 1 chunk +4 lines, -16 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_factory.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/supervised_user/child_accounts/child_account_service.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/supervised_user/legacy/supervised_user_shared_settings_service.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.cc View 1 chunk +6 lines, -14 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_whitelist_service.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/themes/theme_service_factory.cc View 1 chunk +10 lines, -24 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_prefs.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/ash/chrome_launcher_prefs.cc View 1 chunk +6 lines, -19 lines 0 comments Download
M chrome/browser/ui/browser_ui_prefs.cc View 3 chunks +26 lines, -100 lines 0 comments Download
M chrome/browser/ui/browser_view_prefs.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/window_size_autosaver_unittest.mm View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/gesture_prefs_observer_factory_aura.cc View 2 chunks +8 lines, -16 lines 0 comments Download
M chrome/browser/ui/network_profile_bubble.cc View 1 1 chunk +3 lines, -8 lines 0 comments Download
M chrome/browser/ui/passwords/password_bubble_experiment.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 5 chunks +44 lines, -100 lines 0 comments Download
M chrome/browser/ui/startup/autolaunch_prompt_win.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/tabs/pinned_tab_codec.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_bar.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/flags_ui.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/instant_ui.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/ntp/foreign_session_handler.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/most_visited_handler.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_page_handler.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/sticky_settings.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/web_resource/notification_promo.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/web_resource/promo_resource_service.cc View 1 chunk +1 line, -4 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 2 chunks +12 lines, -31 lines 0 comments Download
M components/autofill/core/browser/autofill_test_utils.cc View 1 chunk +5 lines, -10 lines 0 comments Download
M components/bookmarks/browser/bookmark_expanded_state_tracker_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M components/bookmarks/browser/bookmark_utils.cc View 1 chunk +1 line, -4 lines 0 comments Download
M components/content_settings/core/browser/content_settings_default_provider.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M components/content_settings/core/browser/content_settings_policy_provider.cc View 1 chunk +30 lines, -60 lines 0 comments Download
M components/content_settings/core/browser/content_settings_pref_provider.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M components/content_settings/core/browser/host_content_settings_map.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs.cc View 1 chunk +19 lines, -53 lines 0 comments Download
M components/enhanced_bookmarks/bookmark_server_cluster_service.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/gcm_driver/gcm_channel_status_syncer.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M components/invalidation/invalidator_storage.cc View 1 chunk +5 lines, -12 lines 0 comments Download
M components/password_manager/core/browser/password_manager.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M components/policy/core/browser/url_blacklist_manager.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M components/search_engines/default_search_manager.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/search_engines/template_url_prepopulate_data.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M components/suggestions/blacklist_store.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/suggestions/suggestions_store.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/sync_driver/sync_prefs.cc View 3 chunks +15 lines, -51 lines 0 comments Download
M components/translate/core/browser/translate_prefs.cc View 1 chunk +1 line, -3 lines 0 comments Download
M extensions/browser/extension_prefs.cc View 1 3 chunks +11 lines, -27 lines 0 comments Download
M ios/chrome/browser/first_run/first_run.mm View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
raymes
5 years, 8 months ago (2015-04-23 07:41:44 UTC) #2
Mattias Nissler (ping if slow)
Sweet! LGTM
5 years, 8 months ago (2015-04-23 07:54:12 UTC) #3
raymes
+brettw for top level OWNERS
5 years, 8 months ago (2015-04-24 00:53:41 UTC) #5
brettw
LGTM rubberstamp
5 years, 8 months ago (2015-04-24 17:25:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102733002/20001
5 years, 8 months ago (2015-04-27 01:45:41 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-27 03:00:37 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 03:01:37 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aa60872e346eaf354bb15dbd698546b1bdddd132
Cr-Commit-Position: refs/heads/master@{#326993}

Powered by Google App Engine
This is Rietveld 408576698