Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Side by Side Diff: chrome/browser/ui/browser_ui_prefs.cc

Issue 1102733002: Remove most occurences of PrefRegistrySyncable::UNSYNCABLE_PREF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prefs-add-reg-funcs
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/ash/chrome_launcher_prefs.cc ('k') | chrome/browser/ui/browser_view_prefs.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser_ui_prefs.h" 5 #include "chrome/browser/ui/browser_ui_prefs.h"
6 6
7 #include "base/prefs/pref_registry_simple.h" 7 #include "base/prefs/pref_registry_simple.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "base/prefs/scoped_user_pref_update.h" 9 #include "base/prefs/scoped_user_pref_update.h"
10 #include "chrome/browser/first_run/first_run.h" 10 #include "chrome/browser/first_run/first_run.h"
(...skipping 22 matching lines...) Expand all
33 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 33 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
34 #if defined(OS_MACOSX) 34 #if defined(OS_MACOSX)
35 // This really belongs in platform code, but there's no good place to 35 // This really belongs in platform code, but there's no good place to
36 // initialize it between the time when the AppController is created 36 // initialize it between the time when the AppController is created
37 // (where there's no profile) and the time the controller gets another 37 // (where there's no profile) and the time the controller gets another
38 // crack at the start of the main event loop. By that time, 38 // crack at the start of the main event loop. By that time,
39 // StartupBrowserCreator has already created the browser window, and it's too 39 // StartupBrowserCreator has already created the browser window, and it's too
40 // late: we need the pref to be already initialized. Doing it here also saves 40 // late: we need the pref to be already initialized. Doing it here also saves
41 // us from having to hard-code pref registration in the several unit tests 41 // us from having to hard-code pref registration in the several unit tests
42 // that use this preference. 42 // that use this preference.
43 registry->RegisterBooleanPref( 43 registry->RegisterBooleanPref(prefs::kShowUpdatePromotionInfoBar, true);
44 prefs::kShowUpdatePromotionInfoBar,
45 true,
46 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
47 #endif 44 #endif
48 registry->RegisterBooleanPref( 45 registry->RegisterBooleanPref(
49 prefs::kDeleteBrowsingHistory, 46 prefs::kDeleteBrowsingHistory,
50 true, 47 true,
51 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 48 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
52 registry->RegisterBooleanPref( 49 registry->RegisterBooleanPref(
53 prefs::kDeleteDownloadHistory, 50 prefs::kDeleteDownloadHistory,
54 true, 51 true,
55 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 52 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
56 registry->RegisterBooleanPref( 53 registry->RegisterBooleanPref(
(...skipping 13 matching lines...) Expand all
70 false, 67 false,
71 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 68 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
72 registry->RegisterBooleanPref( 69 registry->RegisterBooleanPref(
73 prefs::kDeleteHostedAppsData, 70 prefs::kDeleteHostedAppsData,
74 false, 71 false,
75 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 72 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
76 registry->RegisterIntegerPref( 73 registry->RegisterIntegerPref(
77 prefs::kDeleteTimePeriod, 74 prefs::kDeleteTimePeriod,
78 0, 75 0,
79 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 76 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
80 registry->RegisterInt64Pref( 77 registry->RegisterInt64Pref(prefs::kLastClearBrowsingDataTime, 0);
81 prefs::kLastClearBrowsingDataTime, 78 registry->RegisterIntegerPref(prefs::kModuleConflictBubbleShown, 0);
82 0, 79 registry->RegisterBooleanPref(prefs::kCheckDefaultBrowser, true);
83 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF); 80 registry->RegisterBooleanPref(prefs::kWebAppCreateOnDesktop, true);
84 registry->RegisterIntegerPref(prefs::kModuleConflictBubbleShown, 81 registry->RegisterBooleanPref(prefs::kWebAppCreateInAppsMenu, true);
85 0, 82 registry->RegisterBooleanPref(prefs::kWebAppCreateInQuickLaunchBar, true);
86 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
87 registry->RegisterBooleanPref(
88 prefs::kCheckDefaultBrowser,
89 true,
90 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
91 registry->RegisterBooleanPref(
92 prefs::kWebAppCreateOnDesktop,
93 true,
94 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
95 registry->RegisterBooleanPref(
96 prefs::kWebAppCreateInAppsMenu,
97 true,
98 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
99 registry->RegisterBooleanPref(
100 prefs::kWebAppCreateInQuickLaunchBar,
101 true,
102 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
103 registry->RegisterBooleanPref( 83 registry->RegisterBooleanPref(
104 prefs::kEnableTranslate, 84 prefs::kEnableTranslate,
105 true, 85 true,
106 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 86 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
107 registry->RegisterStringPref( 87 registry->RegisterStringPref(prefs::kCloudPrintEmail, std::string());
108 prefs::kCloudPrintEmail, 88 registry->RegisterBooleanPref(prefs::kCloudPrintProxyEnabled, true);
109 std::string(), 89 registry->RegisterBooleanPref(prefs::kCloudPrintSubmitEnabled, true);
110 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF); 90 registry->RegisterBooleanPref(prefs::kDevToolsDisabled, false);
111 registry->RegisterBooleanPref( 91 registry->RegisterDictionaryPref(prefs::kBrowserWindowPlacement);
112 prefs::kCloudPrintProxyEnabled, 92 registry->RegisterDictionaryPref(prefs::kBrowserWindowPlacementPopup);
113 true, 93 registry->RegisterDictionaryPref(prefs::kAppWindowPlacement);
114 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF); 94 registry->RegisterBooleanPref(prefs::kImportAutofillFormData, true);
115 registry->RegisterBooleanPref( 95 registry->RegisterBooleanPref(prefs::kImportBookmarks, true);
116 prefs::kCloudPrintSubmitEnabled, 96 registry->RegisterBooleanPref(prefs::kImportHistory, true);
117 true, 97 registry->RegisterBooleanPref(prefs::kImportHomepage, true);
118 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF); 98 registry->RegisterBooleanPref(prefs::kImportSavedPasswords, true);
119 registry->RegisterBooleanPref( 99 registry->RegisterBooleanPref(prefs::kImportSearchEngine, true);
120 prefs::kDevToolsDisabled,
121 false,
122 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
123 registry->RegisterDictionaryPref(
124 prefs::kBrowserWindowPlacement,
125 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
126 registry->RegisterDictionaryPref(
127 prefs::kBrowserWindowPlacementPopup,
128 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
129 registry->RegisterDictionaryPref(
130 prefs::kAppWindowPlacement,
131 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
132 registry->RegisterBooleanPref(
133 prefs::kImportAutofillFormData,
134 true,
135 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
136 registry->RegisterBooleanPref(
137 prefs::kImportBookmarks,
138 true,
139 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
140 registry->RegisterBooleanPref(
141 prefs::kImportHistory,
142 true,
143 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
144 registry->RegisterBooleanPref(
145 prefs::kImportHomepage,
146 true,
147 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
148 registry->RegisterBooleanPref(
149 prefs::kImportSavedPasswords,
150 true,
151 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
152 registry->RegisterBooleanPref(
153 prefs::kImportSearchEngine,
154 true,
155 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
156 registry->RegisterBooleanPref( 100 registry->RegisterBooleanPref(
157 prefs::kEnableDoNotTrack, 101 prefs::kEnableDoNotTrack,
158 false, 102 false,
159 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 103 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
160 #if defined(ENABLE_WEBRTC) 104 #if defined(ENABLE_WEBRTC)
161 registry->RegisterBooleanPref( 105 registry->RegisterBooleanPref(prefs::kWebRTCMultipleRoutesEnabled, true);
162 prefs::kWebRTCMultipleRoutesEnabled,
163 true,
164 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
165 #endif 106 #endif
166 107
167 // Dictionaries to keep track of default tasks in the file browser. 108 // Dictionaries to keep track of default tasks in the file browser.
168 registry->RegisterDictionaryPref( 109 registry->RegisterDictionaryPref(
169 prefs::kDefaultTasksByMimeType, 110 prefs::kDefaultTasksByMimeType,
170 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 111 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
171 registry->RegisterDictionaryPref( 112 registry->RegisterDictionaryPref(
172 prefs::kDefaultTasksBySuffix, 113 prefs::kDefaultTasksBySuffix,
173 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 114 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
174 115
175 // We need to register the type of these preferences in order to query 116 // We need to register the type of these preferences in order to query
176 // them even though they're only typically controlled via policy. 117 // them even though they're only typically controlled via policy.
177 registry->RegisterBooleanPref( 118 registry->RegisterBooleanPref(prefs::kPluginsAllowOutdated, false);
178 prefs::kPluginsAllowOutdated, 119 registry->RegisterBooleanPref(prefs::kPluginsAlwaysAuthorize, false);
179 false, 120 registry->RegisterBooleanPref(prefs::kClearPluginLSODataEnabled, true);
180 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF); 121 registry->RegisterBooleanPref(prefs::kHideWebStoreIcon, false);
181 registry->RegisterBooleanPref(
182 prefs::kPluginsAlwaysAuthorize,
183 false,
184 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
185 registry->RegisterBooleanPref(
186 prefs::kClearPluginLSODataEnabled,
187 true,
188 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
189 registry->RegisterBooleanPref(
190 prefs::kHideWebStoreIcon,
191 false,
192 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
193 #if !defined(OS_MACOSX) 122 #if !defined(OS_MACOSX)
194 registry->RegisterBooleanPref( 123 registry->RegisterBooleanPref(prefs::kFullscreenAllowed, true);
195 prefs::kFullscreenAllowed,
196 true,
197 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
198 #endif 124 #endif
199 } 125 }
200 126
201 } // namespace chrome 127 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/browser/ui/ash/chrome_launcher_prefs.cc ('k') | chrome/browser/ui/browser_view_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698