chrome/browser/notifications/extension_welcome_notification.cc - Issue 1102733002: Remove most occurences of PrefRegistrySyncable::UNSYNCABLE_PREF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/extension_welcome_notification.cc

Issue 1102733002: Remove most occurences of PrefRegistrySyncable::UNSYNCABLE_PREF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prefs-add-reg-funcs

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/desktop_notification_service.cc ('k') | chrome/browser/password_manager/password_store_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/extension_welcome_notification.cc

diff --git a/chrome/browser/notifications/extension_welcome_notification.cc b/chrome/browser/notifications/extension_welcome_notification.cc

index 335ebb8fc3c53e6363c39d1ba8a762836ec6ff7a..5cb62ca43f67c1b85c7c78e275da9654d60cdc38 100644

--- a/chrome/browser/notifications/extension_welcome_notification.cc

+++ b/chrome/browser/notifications/extension_welcome_notification.cc

@@ -218,15 +218,10 @@ void ExtensionWelcomeNotification::RegisterProfilePrefs(

prefs->RegisterBooleanPref(prefs::kWelcomeNotificationDismissed,

false,

user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);

- prefs->RegisterBooleanPref(prefs::kWelcomeNotificationDismissedLocal,

- false,

- user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);

+ prefs->RegisterBooleanPref(prefs::kWelcomeNotificationDismissedLocal, false);

prefs->RegisterBooleanPref(prefs::kWelcomeNotificationPreviouslyPoppedUp,

- false,

- user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);

- prefs->RegisterInt64Pref(prefs::kWelcomeNotificationExpirationTimestamp,

- 0,

- user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);

+ false);

+ prefs->RegisterInt64Pref(prefs::kWelcomeNotificationExpirationTimestamp, 0);

}

message_center::MessageCenter*