chrome/browser/plugins/plugin_prefs_factory.cc - Issue 1102733002: Remove most occurences of PrefRegistrySyncable::UNSYNCABLE_PREF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugins/plugin_prefs_factory.cc

Issue 1102733002: Remove most occurences of PrefRegistrySyncable::UNSYNCABLE_PREF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prefs-add-reg-funcs

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/pepper_flash_settings_manager.cc ('k') | chrome/browser/policy/cloud/user_policy_signin_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/plugins/plugin_prefs_factory.cc

diff --git a/chrome/browser/plugins/plugin_prefs_factory.cc b/chrome/browser/plugins/plugin_prefs_factory.cc

index 862fa91b6083ca5d866c19ad37ad079782d8dcf8..6e176b5d96b651f46e6cbc487dfed9ea586273d7 100644

--- a/chrome/browser/plugins/plugin_prefs_factory.cc

+++ b/chrome/browser/plugins/plugin_prefs_factory.cc

@@ -55,30 +55,16 @@ void PluginPrefsFactory::RegisterProfilePrefs(

user_prefs::PrefRegistrySyncable* registry) {

base::FilePath internal_dir;

PathService::Get(chrome::DIR_INTERNAL_PLUGINS, &internal_dir);

- registry->RegisterFilePathPref(

- prefs::kPluginsLastInternalDirectory,

- internal_dir,

- user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);

+ registry->RegisterFilePathPref(prefs::kPluginsLastInternalDirectory,

+ internal_dir);

+ registry->RegisterBooleanPref(prefs::kPluginsMigratedToPepperFlash, false);

registry->RegisterBooleanPref(

- prefs::kPluginsMigratedToPepperFlash,

- false,

- user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);

- registry->RegisterBooleanPref(

- prefs::kPluginsRemovedOldComponentPepperFlashSettings,

- false,

- user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);

- registry->RegisterListPref(prefs::kPluginsPluginsList,

- user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);

- registry->RegisterListPref(prefs::kPluginsDisabledPlugins,

- user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);

- registry->RegisterListPref(prefs::kPluginsDisabledPluginsExceptions,

- user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);

- registry->RegisterListPref(prefs::kPluginsEnabledPlugins,

- user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);

- registry->RegisterBooleanPref(

- prefs::kEnableNpapi,

- false,

- user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);

+ prefs::kPluginsRemovedOldComponentPepperFlashSettings, false);

+ registry->RegisterListPref(prefs::kPluginsPluginsList);

+ registry->RegisterListPref(prefs::kPluginsDisabledPlugins);

+ registry->RegisterListPref(prefs::kPluginsDisabledPluginsExceptions);

+ registry->RegisterListPref(prefs::kPluginsEnabledPlugins);

+ registry->RegisterBooleanPref(prefs::kEnableNpapi, false);

}

content::BrowserContext* PluginPrefsFactory::GetBrowserContextToUse(