Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Side by Side Diff: components/autofill/core/browser/autofill_manager.cc

Issue 1102733002: Remove most occurences of PrefRegistrySyncable::UNSYNCABLE_PREF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prefs-add-reg-funcs
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/core/browser/autofill_manager.h" 5 #include "components/autofill/core/browser/autofill_manager.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <limits> 9 #include <limits>
10 #include <map> 10 #include <map>
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 159
160 AutofillManager::~AutofillManager() {} 160 AutofillManager::~AutofillManager() {}
161 161
162 // static 162 // static
163 void AutofillManager::RegisterProfilePrefs( 163 void AutofillManager::RegisterProfilePrefs(
164 user_prefs::PrefRegistrySyncable* registry) { 164 user_prefs::PrefRegistrySyncable* registry) {
165 registry->RegisterBooleanPref( 165 registry->RegisterBooleanPref(
166 prefs::kAutofillEnabled, 166 prefs::kAutofillEnabled,
167 true, 167 true,
168 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 168 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
169 registry->RegisterBooleanPref( 169 registry->RegisterBooleanPref(prefs::kAutofillWalletSyncExperimentEnabled,
170 prefs::kAutofillWalletSyncExperimentEnabled, 170 false);
171 false,
172 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
173 // TODO(estade): Should this be syncable? 171 // TODO(estade): Should this be syncable?
174 registry->RegisterBooleanPref( 172 registry->RegisterBooleanPref(
175 prefs::kAutofillWalletImportEnabled, 173 prefs::kAutofillWalletImportEnabled,
176 true, 174 true,
177 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 175 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
178 // This choice is made on a per-device basis, so it's not syncable. 176 // This choice is made on a per-device basis, so it's not syncable.
179 registry->RegisterBooleanPref( 177 registry->RegisterBooleanPref(
180 prefs::kAutofillWalletImportStorageCheckboxState, 178 prefs::kAutofillWalletImportStorageCheckboxState, true);
181 true,
182 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
183 #if defined(OS_MACOSX) 179 #if defined(OS_MACOSX)
184 registry->RegisterBooleanPref( 180 registry->RegisterBooleanPref(
185 prefs::kAutofillAuxiliaryProfilesEnabled, 181 prefs::kAutofillAuxiliaryProfilesEnabled,
186 true, 182 true,
187 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 183 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
188 #else // defined(OS_MACOSX) 184 #else // defined(OS_MACOSX)
189 registry->RegisterBooleanPref( 185 registry->RegisterBooleanPref(prefs::kAutofillAuxiliaryProfilesEnabled,
190 prefs::kAutofillAuxiliaryProfilesEnabled, 186 false);
191 false,
192 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
193 #endif // defined(OS_MACOSX) 187 #endif // defined(OS_MACOSX)
194 #if defined(OS_MACOSX) 188 #if defined(OS_MACOSX)
195 registry->RegisterBooleanPref( 189 registry->RegisterBooleanPref(prefs::kAutofillMacAddressBookQueried, false);
196 prefs::kAutofillMacAddressBookQueried,
197 false,
198 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
199 #endif // defined(OS_MACOSX) 190 #endif // defined(OS_MACOSX)
200 registry->RegisterDoublePref( 191 registry->RegisterDoublePref(prefs::kAutofillPositiveUploadRate,
201 prefs::kAutofillPositiveUploadRate, 192 kAutofillPositiveUploadRateDefaultValue);
202 kAutofillPositiveUploadRateDefaultValue, 193 registry->RegisterDoublePref(prefs::kAutofillNegativeUploadRate,
203 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF); 194 kAutofillNegativeUploadRateDefaultValue);
204 registry->RegisterDoublePref(
205 prefs::kAutofillNegativeUploadRate,
206 kAutofillNegativeUploadRateDefaultValue,
207 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
208 195
209 #if defined(OS_MACOSX) && !defined(OS_IOS) 196 #if defined(OS_MACOSX) && !defined(OS_IOS)
210 registry->RegisterBooleanPref( 197 registry->RegisterBooleanPref(prefs::kAutofillUseMacAddressBook, false);
211 prefs::kAutofillUseMacAddressBook, 198 registry->RegisterIntegerPref(prefs::kAutofillMacAddressBookShowedCount, 0);
212 false,
213 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
214 registry->RegisterIntegerPref(
215 prefs::kAutofillMacAddressBookShowedCount,
216 0,
217 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
218 #endif // defined(OS_MACOSX) && !defined(OS_IOS) 199 #endif // defined(OS_MACOSX) && !defined(OS_IOS)
219 } 200 }
220 201
221 #if defined(OS_MACOSX) && !defined(OS_IOS) 202 #if defined(OS_MACOSX) && !defined(OS_IOS)
222 void AutofillManager::MigrateUserPrefs(PrefService* prefs) { 203 void AutofillManager::MigrateUserPrefs(PrefService* prefs) {
223 const PrefService::Preference* pref = 204 const PrefService::Preference* pref =
224 prefs->FindPreference(prefs::kAutofillUseMacAddressBook); 205 prefs->FindPreference(prefs::kAutofillUseMacAddressBook);
225 206
226 // If the pref is not its default value, then the migration has already been 207 // If the pref is not its default value, then the migration has already been
227 // performed. 208 // performed.
(...skipping 1303 matching lines...) Expand 10 before | Expand all | Expand 10 after
1531 return false; 1512 return false;
1532 1513
1533 // Disregard forms that we wouldn't ever autofill in the first place. 1514 // Disregard forms that we wouldn't ever autofill in the first place.
1534 if (!form.ShouldBeParsed()) 1515 if (!form.ShouldBeParsed())
1535 return false; 1516 return false;
1536 1517
1537 return true; 1518 return true;
1538 } 1519 }
1539 1520
1540 } // namespace autofill 1521 } // namespace autofill
OLDNEW
« no previous file with comments | « chrome/browser/web_resource/promo_resource_service.cc ('k') | components/autofill/core/browser/autofill_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698