chrome/browser/bookmarks/bookmark_model_factory.cc - Issue 1102733002: Remove most occurences of PrefRegistrySyncable::UNSYNCABLE_PREF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bookmarks/bookmark_model_factory.cc

Issue 1102733002: Remove most occurences of PrefRegistrySyncable::UNSYNCABLE_PREF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prefs-add-reg-funcs

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/background/background_contents_service_factory.cc ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/bookmarks/bookmark_model_factory.cc

diff --git a/chrome/browser/bookmarks/bookmark_model_factory.cc b/chrome/browser/bookmarks/bookmark_model_factory.cc

index e0f7e802536f17997ee125911fcf8d237d7cd7aa..e031858f89db8cbeacde41aa85f34b0bff6c10f4 100644

--- a/chrome/browser/bookmarks/bookmark_model_factory.cc

+++ b/chrome/browser/bookmarks/bookmark_model_factory.cc

@@ -88,14 +88,9 @@ void BookmarkModelFactory::RegisterProfilePrefs(

// want to sync the expanded state of folders, it should be part of

// bookmark sync itself (i.e., a property of the sync folder nodes).

registry->RegisterListPref(bookmarks::prefs::kBookmarkEditorExpandedNodes,

- new base::ListValue,

- user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);

- registry->RegisterListPref(

- bookmarks::prefs::kManagedBookmarks,

- user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);

- registry->RegisterListPref(

- bookmarks::prefs::kSupervisedBookmarks,

- user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);

+ new base::ListValue);

+ registry->RegisterListPref(bookmarks::prefs::kManagedBookmarks);

+ registry->RegisterListPref(bookmarks::prefs::kSupervisedBookmarks);

}

content::BrowserContext* BookmarkModelFactory::GetBrowserContextToUse(