Remove most occurences of PrefRegistrySyncable::UNSYNCABLE_PREF

chrome/browser/ui/prefs/prefs_tab_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/prefs/prefs_tab_helper.h"
 
 #include <set>
 #include <string>
 
 #include "base/memory/singleton.h"
@@ skipping 106 matching lines @@
 ALL_FONT_SCRIPTS(WEBKIT_WEBPREFS_FONTS_STANDARD)
 
 #undef EXPAND_SCRIPT_FONT
   };
 
   for (size_t i = 0; i < arraysize(kFontFamilyMap); ++i) {
     const char* pref_name = kFontFamilyMap[i];
     if (fonts_with_defaults.find(pref_name) == fonts_with_defaults.end()) {
       // We haven't already set a default value for this font preference, so set
       // an empty string as the default.
-      registry->RegisterStringPref(
-          pref_name,
-          std::string(),
-          user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
+      registry->RegisterStringPref(pref_name, std::string());
     }
   }
 }
 #endif  // !defined(OS_ANDROID)
 
 // Registers |obs| to observe per-script font prefs under the path |map_name|.
 // On android, there's no exposed way to change these prefs, so we can save
 // ~715KB of heap and some startup cycles by avoiding observing these prefs
 // since they will never change.
 void RegisterFontFamilyMapObserver(
@@ skipping 179 matching lines @@
     map = &prefs->fantasy_font_family_map;
   else if (generic_family == "pictograph")
     map = &prefs->pictograph_font_family_map;
   else
     NOTREACHED() << "Unknown generic font family: " << generic_family;
   (*map)[script] = base::UTF8ToUTF16(pref_value);
 }
 
 void RegisterLocalizedFontPref(user_prefs::PrefRegistrySyncable* registry,
                                const char* path,
-                               int default_message_id,
-                               uint32 flags) {
+                               int default_message_id) {
   int val = 0;
   bool success = base::StringToInt(l10n_util::GetStringUTF8(
       default_message_id), &val);
   DCHECK(success);
-  registry->RegisterIntegerPref(path, val, flags);
+  registry->RegisterIntegerPref(path, val);
 }
 
 }  // namespace
 
 // Watching all these settings per tab is slow when a user has a lot of tabs and
 // and they use session restore. So watch them once per profile.
 // http://crbug.com/452693
 class PrefWatcher : public KeyedService {
  public:
   explicit PrefWatcher(Profile* profile) : profile_(profile) {
@@ skipping 169 matching lines @@
   pref_store->RegisterOverlayPref(prefs::kSaveFileDefaultDirectory);
 #if defined(OS_ANDROID) || defined(OS_IOS)
   pref_store->RegisterOverlayPref(prefs::kProxy);
 #endif  // defined(OS_ANDROID) || defined(OS_IOS)
 }
 
 // static
 void PrefsTabHelper::RegisterProfilePrefs(
     user_prefs::PrefRegistrySyncable* registry) {
   WebPreferences pref_defaults;
+  registry->RegisterBooleanPref(prefs::kWebKitJavascriptEnabled,
+                                pref_defaults.javascript_enabled);
+  registry->RegisterBooleanPref(prefs::kWebKitWebSecurityEnabled,
+                                pref_defaults.web_security_enabled);
   registry->RegisterBooleanPref(
-      prefs::kWebKitJavascriptEnabled,
-      pref_defaults.javascript_enabled,
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-  registry->RegisterBooleanPref(
-      prefs::kWebKitWebSecurityEnabled,
-      pref_defaults.web_security_enabled,
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-  registry->RegisterBooleanPref(
-      prefs::kWebKitJavascriptCanOpenWindowsAutomatically,
-      true,
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-  registry->RegisterBooleanPref(
-      prefs::kWebKitLoadsImagesAutomatically,
-      pref_defaults.loads_images_automatically,
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-  registry->RegisterBooleanPref(
-      prefs::kWebKitPluginsEnabled,
-      pref_defaults.plugins_enabled,
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-  registry->RegisterBooleanPref(
-      prefs::kWebKitDomPasteEnabled,
-      pref_defaults.dom_paste_enabled,
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-  registry->RegisterBooleanPref(
-      prefs::kWebKitShrinksStandaloneImagesToFit,
-      pref_defaults.shrinks_standalone_images_to_fit,
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-  registry->RegisterBooleanPref(
-      prefs::kWebKitTextAreasAreResizable,
-      pref_defaults.text_areas_are_resizable,
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-  registry->RegisterBooleanPref(
-      prefs::kWebKitJavaEnabled,
-      pref_defaults.java_enabled,
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-  registry->RegisterBooleanPref(
-      prefs::kWebkitTabsToLinks,
-      pref_defaults.tabs_to_links,
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-  registry->RegisterBooleanPref(
-      prefs::kWebKitAllowRunningInsecureContent,
-      false,
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-  registry->RegisterBooleanPref(
-      prefs::kWebKitAllowDisplayingInsecureContent,
-      true,
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-  registry->RegisterBooleanPref(
-      prefs::kEnableReferrers,
-      true,
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
+      prefs::kWebKitJavascriptCanOpenWindowsAutomatically, true);
+  registry->RegisterBooleanPref(prefs::kWebKitLoadsImagesAutomatically,
+                                pref_defaults.loads_images_automatically);
+  registry->RegisterBooleanPref(prefs::kWebKitPluginsEnabled,
+                                pref_defaults.plugins_enabled);
+  registry->RegisterBooleanPref(prefs::kWebKitDomPasteEnabled,
+                                pref_defaults.dom_paste_enabled);
+  registry->RegisterBooleanPref(prefs::kWebKitShrinksStandaloneImagesToFit,
+                                pref_defaults.shrinks_standalone_images_to_fit);
+  registry->RegisterBooleanPref(prefs::kWebKitTextAreasAreResizable,
+                                pref_defaults.text_areas_are_resizable);
+  registry->RegisterBooleanPref(prefs::kWebKitJavaEnabled,
+                                pref_defaults.java_enabled);
+  registry->RegisterBooleanPref(prefs::kWebkitTabsToLinks,
+                                pref_defaults.tabs_to_links);
+  registry->RegisterBooleanPref(prefs::kWebKitAllowRunningInsecureContent,
+                                false);
+  registry->RegisterBooleanPref(prefs::kWebKitAllowDisplayingInsecureContent,
+                                true);
+  registry->RegisterBooleanPref(prefs::kEnableReferrers, true);
 #if defined(OS_ANDROID)
-  registry->RegisterDoublePref(
-      prefs::kWebKitFontScaleFactor,
-      1.0,
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-  registry->RegisterBooleanPref(
-      prefs::kWebKitForceEnableZoom,
-      pref_defaults.force_enable_zoom,
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-  registry->RegisterBooleanPref(
-      prefs::kWebKitPasswordEchoEnabled,
-      pref_defaults.password_echo_enabled,
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
+  registry->RegisterDoublePref(prefs::kWebKitFontScaleFactor, 1.0);
+  registry->RegisterBooleanPref(prefs::kWebKitForceEnableZoom,
+                                pref_defaults.force_enable_zoom);
+  registry->RegisterBooleanPref(prefs::kWebKitPasswordEchoEnabled,
+                                pref_defaults.password_echo_enabled);
 #endif
   registry->RegisterStringPref(
       prefs::kAcceptLanguages,
       l10n_util::GetStringUTF8(IDS_ACCEPT_LANGUAGES),
       user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
   registry->RegisterStringPref(
       prefs::kDefaultCharset,
       l10n_util::GetStringUTF8(IDS_DEFAULT_ENCODING),
       user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
 
@@ skipping 19 matching lines @@
     // the default is suppressed.  Otherwise, the default would override the
     // user's font preferences when viewing pages in their native language.
     // This is because users have no way yet of customizing their per-script
     // font preferences.  The font prefs accessible in the options UI are for
     // the default, unknown script; these prefs have less priority than the
     // per-script font prefs when the script of the content is known.  This code
     // can possibly be removed later if users can easily access per-script font
     // prefs (e.g., via the extensions workflow), or the problem turns out to
     // not be really critical after all.
     if (browser_script != pref_script) {
-      registry->RegisterStringPref(
-          pref.pref_name,
-          l10n_util::GetStringUTF8(pref.resource_id),
-          user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
+      registry->RegisterStringPref(pref.pref_name,
+                                   l10n_util::GetStringUTF8(pref.resource_id));
       fonts_with_defaults.insert(pref.pref_name);
     }
   }
 
   // Register per-script font prefs that don't have defaults.
 #if !defined(OS_ANDROID)
   RegisterFontFamilyPrefs(registry, fonts_with_defaults);
 #endif
 
-  RegisterLocalizedFontPref(
-      registry,
-      prefs::kWebKitDefaultFontSize,
-      IDS_DEFAULT_FONT_SIZE,
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-  RegisterLocalizedFontPref(
-      registry,
-      prefs::kWebKitDefaultFixedFontSize,
-      IDS_DEFAULT_FIXED_FONT_SIZE,
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-  RegisterLocalizedFontPref(
-      registry,
-      prefs::kWebKitMinimumFontSize,
-      IDS_MINIMUM_FONT_SIZE,
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-  RegisterLocalizedFontPref(
-      registry,
-      prefs::kWebKitMinimumLogicalFontSize,
-      IDS_MINIMUM_LOGICAL_FONT_SIZE,
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
+  RegisterLocalizedFontPref(registry, prefs::kWebKitDefaultFontSize,
+                            IDS_DEFAULT_FONT_SIZE);
+  RegisterLocalizedFontPref(registry, prefs::kWebKitDefaultFixedFontSize,
+                            IDS_DEFAULT_FIXED_FONT_SIZE);
+  RegisterLocalizedFontPref(registry, prefs::kWebKitMinimumFontSize,
+                            IDS_MINIMUM_FONT_SIZE);
+  RegisterLocalizedFontPref(registry, prefs::kWebKitMinimumLogicalFontSize,
+                            IDS_MINIMUM_LOGICAL_FONT_SIZE);
   registry->RegisterBooleanPref(
       prefs::kWebKitUsesUniversalDetector,
       l10n_util::GetStringUTF8(IDS_USES_UNIVERSAL_DETECTOR) == "true",
       user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
   registry->RegisterStringPref(
       prefs::kStaticEncodings,
-      l10n_util::GetStringUTF8(IDS_STATIC_ENCODING_LIST),
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-  registry->RegisterStringPref(
-      prefs::kRecentlySelectedEncoding,
-      std::string(),
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
+      l10n_util::GetStringUTF8(IDS_STATIC_ENCODING_LIST));
+  registry->RegisterStringPref(prefs::kRecentlySelectedEncoding, std::string());
 }
 
 // static
 void PrefsTabHelper::GetServiceInstance() {
   PrefWatcherFactory::GetInstance();
 }
 
 void PrefsTabHelper::Observe(int type,
                              const content::NotificationSource& source,
                              const content::NotificationDetails& details) {
@@ skipping 56 matching lines @@
   }
 }
 
 void PrefsTabHelper::OnWebPrefChanged(const std::string& pref_name) {
 #if !defined(OS_ANDROID)
   OnFontFamilyPrefChanged(pref_name);
 #endif
 
   web_contents_->GetRenderViewHost()->OnWebkitPreferencesChanged();
 }