Update {virtual,override} to follow C++11 style in chrome.

Update {virtual,override} to follow C++11 style in chrome.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463
Committed: https://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c
Cr-Commit-Position: refs/heads/master@{#326870}

[Nico, 2015-04-24 17:58:17]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-04-24 17:58:19]

lgtm, nice! this should fix thousands of style plugin warnings on the clang/win
bots.

(out of interest, why shell script instead of dcheng's auto-rewriter?)

https://codereview.chromium.org/1100223002/diff/1/chrome/browser/importer/ie_...
File chrome/browser/importer/ie_importer_browsertest_win.cc (right):

https://codereview.chromium.org/1100223002/diff/1/chrome/browser/importer/ie_...
chrome/browser/importer/ie_importer_browsertest_win.cc:402: void
AddKeywords(ScopedVector<TemplateURL> template_urls,
oops! nice

[Nico, 2015-04-24 17:58:29]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-04-24 17:59:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1100223002/1

[dcheng, 2015-04-24 18:05:06]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2015-04-24 18:05:07]

Nick and I talked about this. The two different methods have a lot of overlap,
but also cover some ground that the other does not. Nick's method handles things
the plugin ignores like templated classes and classes that look like Gmock
fixtures to it. The automated method can handle some cases where virtual and
override were both missing, etc.

[Nico, 2015-04-24 18:09:20]

Right, but by using the plugin it by definition fixes all the places the
plugin warns about, while this method doesn't necessarily. (For example,
the plugin still complains about these things in sandbox/:

..\..\sandbox/win/src/eat_resolver.h(18,31) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/eat_resolver.h(28,47) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/eat_resolver.h(33,49) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/eat_resolver.h(36,38) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/filesystem_dispatcher.h(19,27) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/filesystem_dispatcher.h(22,71) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/handle_dispatcher.h(18,23) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/handle_dispatcher.h(21,71) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/named_pipe_dispatcher.h(19,26) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/named_pipe_dispatcher.h(22,71) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/process_mitigations_win32k_dispatcher.h(18,41) :
 warning(clang): [chromium-style] Overriding method must be marked with
'override' or 'final'.
..\..\sandbox/win/src/process_mitigations_win32k_dispatcher.h(21,71) :
 warning(clang): [chromium-style] Overriding method must be marked with
'override' or 'final'.
..\..\sandbox/win/src/process_thread_dispatcher.h(19,30) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/process_thread_dispatcher.h(22,71) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/registry_dispatcher.h(19,25) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/registry_dispatcher.h(22,71) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/service_resolver.h(101,59) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/service_resolver.h(113,35) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/service_resolver.h(116,59) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/service_resolver.h(128,32) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/service_resolver.h(131,59) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/service_resolver.h(21,35) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/service_resolver.h(31,47) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/service_resolver.h(36,60) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/service_resolver.h(41,49) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/service_resolver.h(44,38) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/service_resolver.h(98,33) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/sidestep_resolver.h(18,36) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/sidestep_resolver.h(28,47) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/sidestep_resolver.h(31,38) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/sidestep_resolver.h(44,41) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/sidestep_resolver.h(54,47) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/sidestep_resolver.h(57,38) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/sync_dispatcher.h(19,21) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/sync_dispatcher.h(22,71) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/target_services.h(46,28) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/target_services.h(47,28) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/target_services.h(48,35) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/target_services.h(53,52) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/win2k_threadpool.h(30,29) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/win2k_threadpool.h(34,43) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox/win/src/win2k_threadpool.h(36,45) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox\win\src\address_sanitizer_test.cc(21,16) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox\win\src\address_sanitizer_test.cc(26,19) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox\win\src\ipc_unittest.cc(568,28) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
..\..\sandbox\win\src\ipc_unittest.cc(570,72) :  warning(clang):
[chromium-style] Overriding method must be marked with 'override' or
'final'.
)

Doesn't hurt to do both, I guess, but I kinda feel that getting the
clang/win bot plugin warnings down is maybe more important in the very near
term ?

On Fri, Apr 24, 2015 at 11:05 AM, <dcheng@chromium.org> wrote:

> Nick and I talked about this. The two different methods have a lot of
> overlap,
> but also cover some ground that the other does not. Nick's method handles
> things
> the plugin ignores like templated classes and classes that look like Gmock
> fixtures to it. The automated method can handle some cases where virtual
> and
> override were both missing, etc.
>
> https://codereview.chromium.org/1100223002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2015-04-24 18:09:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-24 18:09:31]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  cast_shell_android on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Nico, 2015-04-24 18:12:05]

Apparently needs rebasing :-)

[ncarter (slow), 2015-04-24 19:11:15]

On 2015/04/24 18:12:05, Nico wrote:
> Apparently needs rebasing :-)

I didn't actually send this out for review yet, but thanks for the lgtm! [I knew
it needed rebasing and I wanted to split off the AddKeywords thing]

[ncarter (slow), 2015-04-24 19:45:28]

The CQ bit was checked by nick@chromium.org

[ncarter (slow), 2015-04-24 19:45:30]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1100223002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2015-04-24 19:46:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1100223002/20001

[commit-bot: I haz the power, 2015-04-24 20:45:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-24 20:46:42]

Patchset 2 (id:??) landed as
https://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c
Cr-Commit-Position: refs/heads/master@{#326870}