Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7222)

Unified Diff: chrome/browser/ui/pdf/pdf_unsupported_feature.cc

Issue 1100223002: Update {virtual,override} to follow C++11 style in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/pdf/pdf_browsertest_base.h ('k') | chrome/browser/ui/startup/autolaunch_prompt_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/pdf/pdf_unsupported_feature.cc
diff --git a/chrome/browser/ui/pdf/pdf_unsupported_feature.cc b/chrome/browser/ui/pdf/pdf_unsupported_feature.cc
index dc40e459eb89f658edae0057095b03eb3ddba1a0..dbdd9d341e3aace86cc3eb5b3927c2915a8ccf15 100644
--- a/chrome/browser/ui/pdf/pdf_unsupported_feature.cc
+++ b/chrome/browser/ui/pdf/pdf_unsupported_feature.cc
@@ -57,16 +57,16 @@ class PDFEnableAdobeReaderPromptClient
: public pdf::OpenPDFInReaderPromptClient {
public:
explicit PDFEnableAdobeReaderPromptClient(Profile* profile);
- virtual ~PDFEnableAdobeReaderPromptClient();
+ ~PDFEnableAdobeReaderPromptClient() override;
// pdf::OpenPDFInReaderPromptClient
- virtual base::string16 GetMessageText() const override;
- virtual base::string16 GetAcceptButtonText() const override;
- virtual base::string16 GetCancelButtonText() const override;
- virtual bool ShouldExpire(
+ base::string16 GetMessageText() const override;
+ base::string16 GetAcceptButtonText() const override;
+ base::string16 GetCancelButtonText() const override;
+ bool ShouldExpire(
const content::LoadCommittedDetails& details) const override;
- virtual void Accept() override;
- virtual void Cancel() override;
+ void Accept() override;
+ void Cancel() override;
private:
void OnYes();
@@ -163,7 +163,7 @@ class PDFUnsupportedFeatureInterstitial
protected:
// InterstitialPageDelegate implementation.
- virtual std::string GetHTMLContents() override {
+ std::string GetHTMLContents() override {
base::DictionaryValue strings;
strings.SetString(
"title",
@@ -191,7 +191,7 @@ class PDFUnsupportedFeatureInterstitial
return webui::GetI18nTemplateHtml(html, &strings);
}
- virtual void CommandReceived(const std::string& command) override {
+ void CommandReceived(const std::string& command) override {
if (command == "0") {
content::RecordAction(
UserMetricsAction("PDF_ReaderInterstitialCancel"));
@@ -215,8 +215,7 @@ class PDFUnsupportedFeatureInterstitial
interstitial_page_->Proceed();
}
- virtual void OverrideRendererPrefs(
- content::RendererPreferences* prefs) override {
+ void OverrideRendererPrefs(content::RendererPreferences* prefs) override {
Profile* profile =
Profile::FromBrowserContext(web_contents_->GetBrowserContext());
renderer_preferences_util::UpdateFromSystemSettings(
@@ -238,16 +237,16 @@ class PDFUnsupportedFeaturePromptClient
public:
PDFUnsupportedFeaturePromptClient(WebContents* web_contents,
const AdobeReaderPluginInfo& reader_info);
- virtual ~PDFUnsupportedFeaturePromptClient();
+ ~PDFUnsupportedFeaturePromptClient() override;
// pdf::OpenPDFInReaderPromptClient:
- virtual base::string16 GetMessageText() const override;
- virtual base::string16 GetAcceptButtonText() const override;
- virtual base::string16 GetCancelButtonText() const override;
- virtual bool ShouldExpire(
+ base::string16 GetMessageText() const override;
+ base::string16 GetAcceptButtonText() const override;
+ base::string16 GetCancelButtonText() const override;
+ bool ShouldExpire(
const content::LoadCommittedDetails& details) const override;
- virtual void Accept() override;
- virtual void Cancel() override;
+ void Accept() override;
+ void Cancel() override;
private:
WebContents* web_contents_;
« no previous file with comments | « chrome/browser/ui/pdf/pdf_browsertest_base.h ('k') | chrome/browser/ui/startup/autolaunch_prompt_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698