chrome/browser/ui/views/menu_controller_test.cc - Issue 1100223002: Update {virtual,override} to follow C++11 style in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/menu_controller_test.cc

Issue 1100223002: Update {virtual,override} to follow C++11 style in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/menu_controller_interactive_uitest.cc ('k') | chrome/browser/ui/views/menu_item_view_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/menu_controller_test.cc

diff --git a/chrome/browser/ui/views/menu_controller_test.cc b/chrome/browser/ui/views/menu_controller_test.cc

index 496ea057de3fa11705c9dc450eec6fccc39e9f12..64b245f330bdfa37d568d5914a5886e372dfa62d 100644

--- a/chrome/browser/ui/views/menu_controller_test.cc

+++ b/chrome/browser/ui/views/menu_controller_test.cc

@@ -13,17 +13,16 @@ class MenuControllerMnemonicTest : public MenuTestBase {

MenuControllerMnemonicTest() {

}

- virtual ~MenuControllerMnemonicTest() {

- }

+ ~MenuControllerMnemonicTest() override {}

// MenuTestBase overrides:

- virtual void BuildMenu(views::MenuItemView* menu) override {

+ void BuildMenu(views::MenuItemView* menu) override {

ASSERT_NE(ui::VKEY_DIVIDE, '/');

menu->AppendMenuItemWithLabel(1, base::ASCIIToUTF16("One&/"));

menu->AppendMenuItemWithLabel(2, base::ASCIIToUTF16("Two"));

}

- virtual void DoTestWithMenuOpen() {

+ void DoTestWithMenuOpen() override {

ASSERT_TRUE(menu()->GetSubmenu()->IsShowing());

KeyPress(KEYCODE,

CreateEventTask(this, &MenuControllerMnemonicTest::Step2));