chrome/browser/local_discovery/service_discovery_client_mdns.cc - Issue 1100223002: Update {virtual,override} to follow C++11 style in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/local_discovery/service_discovery_client_mdns.cc

Issue 1100223002: Update {virtual,override} to follow C++11 style in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/local_discovery/privetv3_session_unittest.cc ('k') | chrome/browser/local_discovery/test_service_discovery_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/local_discovery/service_discovery_client_mdns.cc

diff --git a/chrome/browser/local_discovery/service_discovery_client_mdns.cc b/chrome/browser/local_discovery/service_discovery_client_mdns.cc

index fbd077f91ca88f0dcb33ce184e42a0ff3191f93a..cfaa3cf0e6f6d6f3f6d0a368cde76347a44b0277 100644

--- a/chrome/browser/local_discovery/service_discovery_client_mdns.cc

+++ b/chrome/browser/local_discovery/service_discovery_client_mdns.cc

@@ -145,15 +145,15 @@ class ProxyBase : public ServiceDiscoveryClientMdns::Proxy, public T {

: Proxy(client) {

}

- virtual ~ProxyBase() {

+ ~ProxyBase() override {

DeleteOnMdnsThread(implementation_.release());

}

- virtual bool IsValid() override {

+ bool IsValid() override {

return !!implementation();

}

- virtual void OnMdnsDestroy() override {

+ void OnMdnsDestroy() override {

DeleteOnMdnsThread(implementation_.release());

};