chrome/installer/util/callback_work_item.h - Issue 1100223002: Update {virtual,override} to follow C++11 style in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/callback_work_item.h

Issue 1100223002: Update {virtual,override} to follow C++11 style in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/installer/util/advanced_firewall_manager_win_unittest.cc ('k') | chrome/installer/util/chrome_binaries_operations.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/callback_work_item.h

diff --git a/chrome/installer/util/callback_work_item.h b/chrome/installer/util/callback_work_item.h

index c81d02a5a311c585f3f4f20f5219f60d56e20d4a..3cc22f656ed415a4c1453444d0bffe700ba76b8c 100644

--- a/chrome/installer/util/callback_work_item.h

+++ b/chrome/installer/util/callback_work_item.h

@@ -33,10 +33,10 @@

// }

class CallbackWorkItem : public WorkItem {

public:

- virtual ~CallbackWorkItem();

+ ~CallbackWorkItem() override;

- virtual bool Do() override;

- virtual void Rollback() override;

+ bool Do() override;

+ void Rollback() override;

bool IsRollback() const;