Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: chrome/installer/util/firewall_manager_win.cc

Issue 1100223002: Update {virtual,override} to follow C++11 style in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/firewall_manager_win.cc
diff --git a/chrome/installer/util/firewall_manager_win.cc b/chrome/installer/util/firewall_manager_win.cc
index 0171a6f2d07ac0893be2b59a893197bbb4a5de05..202d06207898c0b96464a670ee33a43c42db3516 100644
--- a/chrome/installer/util/firewall_manager_win.cc
+++ b/chrome/installer/util/firewall_manager_win.cc
@@ -23,23 +23,23 @@ const uint16 kDefaultMdnsPort = 5353;
class FirewallManagerAdvancedImpl : public FirewallManager {
public:
FirewallManagerAdvancedImpl() {}
- virtual ~FirewallManagerAdvancedImpl() {}
+ ~FirewallManagerAdvancedImpl() override {}
bool Init(const base::string16& app_name, const base::FilePath& app_path) {
return manager_.Init(app_name, app_path);
}
// FirewallManager methods.
- virtual bool CanUseLocalPorts() override {
+ bool CanUseLocalPorts() override {
return !manager_.IsFirewallEnabled() || manager_.HasAnyRule();
};
- virtual bool AddFirewallRules() override {
+ bool AddFirewallRules() override {
return manager_.AddUDPRule(GetMdnsRuleName(), GetMdnsRuleDescription(),
kDefaultMdnsPort);
}
- virtual void RemoveFirewallRules() override {
+ void RemoveFirewallRules() override {
manager_.DeleteAllRules();
}
@@ -67,25 +67,25 @@ class FirewallManagerAdvancedImpl : public FirewallManager {
class FirewallManagerLegacyImpl : public FirewallManager {
public:
FirewallManagerLegacyImpl() {}
- virtual ~FirewallManagerLegacyImpl() {}
+ ~FirewallManagerLegacyImpl() override {}
bool Init(const base::string16& app_name, const base::FilePath& app_path) {
return manager_.Init(app_name, app_path);
}
// FirewallManager methods.
- virtual bool CanUseLocalPorts() override {
+ bool CanUseLocalPorts() override {
return !manager_.IsFirewallEnabled() ||
manager_.GetAllowIncomingConnection(NULL);
};
- virtual bool AddFirewallRules() override {
+ bool AddFirewallRules() override {
// Change nothing if rule is set.
return manager_.GetAllowIncomingConnection(NULL) ||
manager_.SetAllowIncomingConnection(true);
}
- virtual void RemoveFirewallRules() override {
+ void RemoveFirewallRules() override {
manager_.DeleteRule();
}
« no previous file with comments | « chrome/installer/util/delete_reg_key_work_item.h ('k') | chrome/installer/util/google_chrome_distribution.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698