chrome/test/base/ui_test_utils.h - Issue 1100223002: Update {virtual,override} to follow C++11 style in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/ui_test_utils.h

Issue 1100223002: Update {virtual,override} to follow C++11 style in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/base/test_chrome_web_ui_controller_factory_browsertest.cc ('k') | chrome/test/base/web_ui_browser_test_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/base/ui_test_utils.h

diff --git a/chrome/test/base/ui_test_utils.h b/chrome/test/base/ui_test_utils.h

index db5c0e0f8dcb3d8c7af31a65ea495b91a1147c89..632b86185f361090066c54d0566315da605a3cb6 100644

--- a/chrome/test/base/ui_test_utils.h

+++ b/chrome/test/base/ui_test_utils.h

@@ -219,9 +219,9 @@ class WindowedNotificationObserverWithDetails

return true;

}

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override {

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override {

const U* details_ptr = content::Details<U>(details).ptr();

if (details_ptr)

details_[source.map_key()] = *details_ptr;